* [PATCH] SuperH IrDA: correct Baud rate error correction
@ 2010-11-19 0:24 Nicolas Kaiser
2010-11-19 0:41 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Kaiser @ 2010-11-19 0:24 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Kuninori Morimoto, irda-users, netdev, linux-kernel
It looks to me as if the second value of rate_err_array is intended
to be a decimal 625. However, with a leading 0 it becomes an octal
constant, and as such evaluates to a decimal 405.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/net/irda/sh_sir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index 00b38bc..52a7c86 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -258,7 +258,7 @@ static int sh_sir_set_baudrate(struct sh_sir_self *self, u32 baudrate)
/* Baud Rate Error Correction x 10000 */
u32 rate_err_array[] = {
- 0000, 0625, 1250, 1875,
+ 0, 625, 1250, 1875,
2500, 3125, 3750, 4375,
5000, 5625, 6250, 6875,
7500, 8125, 8750, 9375,
--
1.7.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] SuperH IrDA: correct Baud rate error correction
2010-11-19 0:24 [PATCH] SuperH IrDA: correct Baud rate error correction Nicolas Kaiser
@ 2010-11-19 0:41 ` Stephen Hemminger
2010-11-19 1:05 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2010-11-19 0:41 UTC (permalink / raw)
To: Nicolas Kaiser
Cc: Samuel Ortiz, Kuninori Morimoto, irda-users, netdev, linux-kernel
On Fri, 19 Nov 2010 01:24:02 +0100
Nicolas Kaiser <nikai@nikai.net> wrote:
> u32 rate_err_array[] = {
> - 0000, 0625, 1250, 1875,
> + 0, 625, 1250, 1875,
> 2500, 3125, 3750, 4375,
> 5000, 5625, 6250, 6875,
> 7500, 8125, 8750, 9375,
While you are at it make that table const.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] SuperH IrDA: correct Baud rate error correction
2010-11-19 0:41 ` Stephen Hemminger
@ 2010-11-19 1:05 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2010-11-19 1:05 UTC (permalink / raw)
To: Stephen Hemminger
Cc: Nicolas Kaiser, Samuel Ortiz, Kuninori Morimoto, irda-users,
netdev, linux-kernel
On Thu, 2010-11-18 at 16:41 -0800, Stephen Hemminger wrote:
> On Fri, 19 Nov 2010 01:24:02 +0100
> Nicolas Kaiser <nikai@nikai.net> wrote:
> > u32 rate_err_array[] = {
> > - 0000, 0625, 1250, 1875,
> > + 0, 625, 1250, 1875,
> > 2500, 3125, 3750, 4375,
> > 5000, 5625, 6250, 6875,
> > 7500, 8125, 8750, 9375,
> While you are at it make that table const.
Good find Nicolas.
static const might be better still.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-19 1:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-19 0:24 [PATCH] SuperH IrDA: correct Baud rate error correction Nicolas Kaiser
2010-11-19 0:41 ` Stephen Hemminger
2010-11-19 1:05 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).