From: "Guy, Wey-Yi" <wey-yi.w.guy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: Stefano Brivio
<stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org>,
"Chatre,
Reinette"
<reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Intel Linux Wireless
<ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 56/62] iwlwifi: Use static const
Date: Mon, 22 Nov 2010 07:37:03 -0800 [thread overview]
Message-ID: <1290440223.7946.0.camel@wwguy-ubuntu> (raw)
In-Reply-To: <2773a20a26f4e326f0849e8ae8fb4f347d6a6ecb.1290305776.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Hi Joe,
On Sat, 2010-11-20 at 18:38 -0800, Joe Perches wrote:
> Using static const generally increases object text and decreases data size.
> It also generally decreases overall object size.
>
> text data bss dec hex filename
> 48644 57 12120 60821 ed95 drivers/net/wireless/b43/phy_n.o.new
> 48661 57 12120 60838 eda6 drivers/net/wireless/b43/phy_n.o.old
> 37906 86 7904 45896 b348 drivers/net/wireless/iwlwifi/iwl-agn-lib.o.new
> 37937 86 7904 45927 b367 drivers/net/wireless/iwlwifi/iwl-agn-lib.o.old
> 37781 523 6752 45056 b000 drivers/net/wireless/iwlwifi/iwl-3945.o.new
> 37781 523 6752 45056 b000 drivers/net/wireless/iwlwifi/iwl-3945.o.old
>
> Changed b43_nphy_write_clip_detection to take a const u16 *
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
> ---
I don't see size difference on 3945, otherwise the patch looks ok to me
Wey
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-22 15:37 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 2:38 [PATCH 00/62] drivers/net: Use static const Joe Perches
2010-11-21 2:38 ` [PATCH 01/62] 3c501: " Joe Perches
2010-11-21 2:38 ` [PATCH 02/62] 3c503: " Joe Perches
2010-11-21 2:38 ` [PATCH 03/62] 3c507: " Joe Perches
2010-11-21 2:38 ` [PATCH 04/62] 3c527: " Joe Perches
2010-11-21 2:38 ` [PATCH 05/62] at1700: " Joe Perches
2010-11-21 2:38 ` [PATCH 06/62] benet: " Joe Perches
2010-11-21 2:38 ` [PATCH 07/62] bnx2: " Joe Perches
2010-11-21 2:38 ` [PATCH 08/62] bnx2x: " Joe Perches
2010-11-21 2:38 ` [PATCH 09/62] can: " Joe Perches
2010-11-21 2:38 ` [PATCH 10/62] chelsio: " Joe Perches
2010-11-21 2:38 ` [PATCH 11/62] cxgb3: " Joe Perches
2010-11-21 2:38 ` [PATCH 12/62] " Joe Perches
2010-11-21 2:38 ` [PATCH 13/62] cxgb4: " Joe Perches
2010-11-21 2:38 ` [PATCH 14/62] cxgb4vf: " Joe Perches
2010-11-22 17:42 ` Casey Leedom
2010-11-21 2:38 ` [PATCH 15/62] e1000: " Joe Perches
2010-11-21 2:38 ` [PATCH 16/62] " Joe Perches
2010-11-21 2:38 ` [PATCH 17/62] e1000e: " Joe Perches
2010-11-21 2:38 ` [PATCH 18/62] e2100: " Joe Perches
2010-11-21 2:38 ` [PATCH 19/62] eepro: " Joe Perches
2010-11-21 2:38 ` [PATCH 20/62] eexpress: " Joe Perches
2010-11-21 2:38 ` [PATCH 21/62] gianfar: " Joe Perches
2010-11-21 2:38 ` [PATCH 22/62] hp: " Joe Perches
2010-11-21 2:38 ` [PATCH 23/62] igb: " Joe Perches
2010-11-21 2:38 ` [PATCH 24/62] irda: " Joe Perches
2010-11-21 2:38 ` [PATCH 25/62] " Joe Perches
2010-11-21 2:38 ` [PATCH 26/62] ixgbe: " Joe Perches
2010-11-21 2:38 ` [PATCH 27/62] ixgbevf: " Joe Perches
2010-11-21 2:38 ` [PATCH 28/62] ixgb: " Joe Perches
2010-11-21 2:38 ` [PATCH 29/62] jme: " Joe Perches
2010-11-21 2:38 ` [PATCH 30/62] ksz884x: " Joe Perches
2010-11-21 2:38 ` [PATCH 31/62] netxen: " Joe Perches
2010-11-21 2:38 ` [PATCH 32/62] ni52: " Joe Perches
2010-11-21 2:38 ` [PATCH 33/62] ni65: " Joe Perches
2010-11-21 2:38 ` [PATCH 34/62] pcmcia: " Joe Perches
2010-11-21 2:38 ` [PATCH 35/62] qlcnic: " Joe Perches
2010-11-21 2:38 ` [PATCH 36/62] qlge: " Joe Perches
2010-11-21 2:38 ` [PATCH 37/62] r8169: " Joe Perches
2010-11-21 2:38 ` [PATCH 38/62] s2io: " Joe Perches
2010-11-22 5:36 ` Jon Mason
2010-11-21 2:38 ` [PATCH 39/62] skfp: " Joe Perches
2010-11-21 2:38 ` [PATCH 40/62] skge: " Joe Perches
2010-11-21 2:38 ` [PATCH 41/62] smc-ultra: " Joe Perches
2010-11-21 2:38 ` [PATCH 42/62] tg3: " Joe Perches
2010-11-21 2:38 ` [PATCH 43/62] tokenring: " Joe Perches
2010-11-21 2:38 ` [PATCH 44/62] tulip: " Joe Perches
2010-11-21 2:38 ` [PATCH 45/62] " Joe Perches
2010-11-21 2:38 ` [PATCH 47/62] vmxnet3: " Joe Perches
2010-11-30 18:15 ` Shreyas Bhatewara
2010-11-30 18:24 ` David Miller
2010-11-30 18:36 ` Joe Perches
2010-11-21 2:38 ` [PATCH 48/62] wan: " Joe Perches
2010-11-21 2:38 ` [PATCH 49/62] wd: " Joe Perches
2010-11-21 2:38 ` [PATCH 50/62] ar9170: Use const Joe Perches
2010-11-21 2:38 ` [PATCH 51/62] ath5k: Use static const Joe Perches
2010-11-21 2:38 ` [PATCH 52/62] ath9k: " Joe Perches
2010-11-21 2:38 ` [PATCH 53/62] carl9170: " Joe Perches
[not found] ` <cover.1290305773.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-11-21 2:38 ` [PATCH 46/62] usb: " Joe Perches
[not found] ` <ed2a5bd07f07601ba12ce3c8fcbce2dd954c35aa.1290305776.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-11-21 14:06 ` Sergei Shtylyov
2010-11-21 2:38 ` [PATCH 54/62] atmel: " Joe Perches
2010-11-21 2:38 ` [PATCH 56/62] iwlwifi: " Joe Perches
[not found] ` <2773a20a26f4e326f0849e8ae8fb4f347d6a6ecb.1290305776.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-11-22 15:37 ` Guy, Wey-Yi [this message]
2010-11-21 2:38 ` [PATCH 58/62] ray_cs: " Joe Perches
2010-11-21 2:39 ` [PATCH 62/62] zd1211rw: Use const Joe Perches
2010-11-21 4:50 ` [PATCH 00/62] drivers/net: Use static const David Miller
2010-11-22 22:10 ` Joe Perches
2010-11-22 22:19 ` David Miller
2010-11-22 22:40 ` Joe Perches
2010-11-23 16:28 ` David Miller
2010-11-21 2:38 ` [PATCH 55/62] b43: " Joe Perches
2010-11-21 2:38 ` [PATCH 57/62] libertas: " Joe Perches
2010-11-21 2:39 ` [PATCH 59/62] rndis_wlan: " Joe Perches
2010-11-21 2:39 ` [PATCH 60/62] rt2x00: " Joe Perches
[not found] ` <d8bfaded20da2265673391a81536d63b0e81dc7f.1290305776.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-11-21 8:58 ` Gertjan van Wingerde
2010-11-21 2:39 ` [PATCH 61/62] wl12xx: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290440223.7946.0.camel@wwguy-ubuntu \
--to=wey-yi.w.guy-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).