Re: [PATCH net 6/6] ovpn: use monotonic clock for peer keepalive timeouts

[Marco Baffo <marco@mandelbit.com>]

> On 06/10/2026 4:42 AM CEST Jakub Kicinski <kuba@kernel.org> wrote:
> 
>  
> On Mon,  8 Jun 2026 17:07:37 +0200 Antonio Quartulli wrote:
> > Replace ktime_get_real_seconds() with the monotonic ktime_get_boottime_seconds()
> > to ensure the keepalive mechanism is robust against system clock modifications.
> 
> Why boottime? Unless there's a reason shouldn't we be using
> plain ktime_get_seconds() which is CLOCK_MONOTONIC?
> 
> (if you decide to respin could you also drop the selftest change
> from this PR and move it to net-next? memory leaks in selftests
> are not important)

Hi Jakub!
ktime_get_boottime() is like ktime_get() but it does not stop when suspended.
From Documentation/core-api/timekeeping.rst :
>ktime_t ktime_get(void)
>CLOCK_MONOTONIC
>Useful for reliable timestamps and measuring short time intervals >accurately. Starts at system boot time but stops during suspend.
>
>ktime_t ktime_get_boottime(void)
>CLOCK_BOOTTIME
>Like ktime_get(), but does not stop when suspended. This can be used >e.g. for key expiration times that need to be synchronized with other >machines across a suspend operation.