[PATCH 2/3] econet: Move to staging

[PATCH 2/3] econet: Move to staging

[Ben Hutchings]

Recent review has revealed several bugs in obscure protocol
implementations that can be exploited by local users for denial of
service or privilege escalation.

The econet protocol (PF_ECONET) is unmaintained.  There appear to be
no published applications for it, and it has never progressed beyond
'experimental' status.

This protocol generally should not be enabled by distributions, since
the cost of a security flaw affecting all installed systems presumably
outweighs the benefit to the few (if any) legitimate users.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 drivers/staging/Kconfig |    2 ++
 net/Kconfig             |    1 -
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index dd94cb2..a9dd984 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -177,5 +177,7 @@ source "drivers/staging/speakup/Kconfig"
 
 source "net/decnet/Kconfig"
 
+source "net/econet/Kconfig"
+
 endif # !STAGING_EXCLUDE_BUILD
 endif # STAGING
diff --git a/net/Kconfig b/net/Kconfig
index 9e4fc29..059c9f1 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -205,7 +205,6 @@ source "net/ipx/Kconfig"
 source "drivers/net/appletalk/Kconfig"
 source "net/x25/Kconfig"
 source "net/lapb/Kconfig"
-source "net/econet/Kconfig"
 source "net/wanrouter/Kconfig"
 source "net/phonet/Kconfig"
 source "net/ieee802154/Kconfig"
-- 
1.7.2.3

Re: [PATCH 2/3] econet: Move to staging

[Stephen Hemminger]

On Tue, 23 Nov 2010 03:52:28 +0000
Ben Hutchings <ben@decadent.org.uk> wrote:

> Recent review has revealed several bugs in obscure protocol
> implementations that can be exploited by local users for denial of
> service or privilege escalation.
> 
> The econet protocol (PF_ECONET) is unmaintained.  There appear to be
> no published applications for it, and it has never progressed beyond
> 'experimental' status.
> 
> This protocol generally should not be enabled by distributions, since
> the cost of a security flaw affecting all installed systems presumably
> outweighs the benefit to the few (if any) legitimate users.
> 
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

This I agree with. Probably the Arcnet devices as well.
Most distro's don't enable it anyway.

Re: [PATCH 2/3] econet: Move to staging

[Greg KH]

On Tue, Nov 23, 2010 at 03:52:28AM +0000, Ben Hutchings wrote:
> Recent review has revealed several bugs in obscure protocol
> implementations that can be exploited by local users for denial of
> service or privilege escalation.
> 
> The econet protocol (PF_ECONET) is unmaintained.  There appear to be
> no published applications for it, and it has never progressed beyond
> 'experimental' status.
> 
> This protocol generally should not be enabled by distributions, since
> the cost of a security flaw affecting all installed systems presumably
> outweighs the benefit to the few (if any) legitimate users.
> 
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
>  drivers/staging/Kconfig |    2 ++
>  net/Kconfig             |    1 -
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index dd94cb2..a9dd984 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -177,5 +177,7 @@ source "drivers/staging/speakup/Kconfig"
>  
>  source "net/decnet/Kconfig"
>  
> +source "net/econet/Kconfig"
> +
>  endif # !STAGING_EXCLUDE_BUILD
>  endif # STAGING
> diff --git a/net/Kconfig b/net/Kconfig
> index 9e4fc29..059c9f1 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -205,7 +205,6 @@ source "net/ipx/Kconfig"
>  source "drivers/net/appletalk/Kconfig"
>  source "net/x25/Kconfig"
>  source "net/lapb/Kconfig"
> -source "net/econet/Kconfig"

No, please move the code itself to drivers/staging/ so we know to then
delete it after a few kernel versions.

thanks,

greg k-h