Re: [PATCH 1/2] usbnet: changes for upcoming cdc_ncm driver

[David Brownell <david-b@pacbell.net>]

On Tue, 2010-11-23 at 17:51 +0100, Alexey Orishko wrote:

> -		skb_queue_tail (&dev->done, skb);
> +	if (skb->len) {
> +		/* all data was already cloned inside NCM driver */

Fix this comment.  NCM isn't the only framing policy which un-batches
RX packets ... RNDIS has done so for a number of years already, and
more recently EEM needs it too ... plus at least one hardware driver.

Also, check pending patches, since I seem to recall one that supports
some hardware (SMSC?) that batches, and needed to update the calling
convention you're using here (i.e. the original one).


> +		if (dev->driver_info->flags & FLAG_MULTI_PACKET)

except ... you documented this flag as affecting TX paths not RX...
> +			dev_kfree_skb_any(skb);
> +		else
> +			usbnet_skb_return(dev, skb);
> +		return;
>  	}
> +
> +	netif_dbg(dev, rx_err, dev->net, "drop\n");
> +error:
> +	dev->net->stats.rx_errors++;
> +	skb_queue_tail(&dev->done, skb);
>  }
>