From: "Vladislav Zolotarov" <vladz@broadcom.com>
To: "Dave Miller" <davem@davemloft.net>
Cc: "Eilon Greenstein" <eilong@broadcom.com>,
"netdev list" <netdev@vger.kernel.org>,
"Eric Dumazet" <eric.dumazet@gmail.com>
Subject: [PATCH net-next] bnx2x: Disable local BHes to prevent a dead-lock situation
Date: Wed, 24 Nov 2010 15:45:10 +0200 [thread overview]
Message-ID: <1290606310.25676.7.camel@lb-tlvb-vladz> (raw)
From: Eric Dumazet <eric.dumazet@gmail.com>
According to Eric's suggestion:
Disable local BHes to prevent a dead-lock situation between sch_direct_xmit()
(Soft_IRQ context) and bnx2x_tx_int (called by bnx2x_run_loopback() - syscall
context), as both are taking a netif_tx_lock().
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
CCing Eric... :)
drivers/net/bnx2x/bnx2x_ethtool.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x_ethtool.c b/drivers/net/bnx2x/bnx2x_ethtool.c
index d02ffbd..0301278 100644
--- a/drivers/net/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/bnx2x/bnx2x_ethtool.c
@@ -1499,8 +1499,15 @@ static int bnx2x_run_loopback(struct bnx2x *bp, int loopback_mode, u8 link_up)
* updates that have been performed while interrupts were
* disabled.
*/
- if (bp->common.int_block == INT_BLOCK_IGU)
+ if (bp->common.int_block == INT_BLOCK_IGU) {
+ /* Disable local BHes to prevent a dead-lock situation between
+ * sch_direct_xmit() and bnx2x_run_loopback() (calling
+ * bnx2x_tx_int()), as both are taking netif_tx_lock().
+ */
+ local_bh_disable();
bnx2x_tx_int(fp_tx);
+ local_bh_enable();
+ }
rx_idx = le16_to_cpu(*fp_rx->rx_cons_sb);
if (rx_idx != rx_start_idx + num_pkts)
--
1.7.0.4
next reply other threads:[~2010-11-24 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 13:45 Vladislav Zolotarov [this message]
2010-11-24 14:04 ` [PATCH net-next] bnx2x: Disable local BHes to prevent a dead-lock situation Eric Dumazet
2010-11-24 14:18 ` Vladislav Zolotarov
2010-11-24 19:09 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-11-24 13:41 Vladislav Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290606310.25676.7.camel@lb-tlvb-vladz \
--to=vladz@broadcom.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox