netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonas Bonn <jonas@southpole.se>
To: netdev@vger.kernel.org
Cc: Jonas Bonn <jonas@southpole.se>
Subject: [PATCH 4/8] ethoc: Double check pending RX packet
Date: Thu, 25 Nov 2010 13:30:28 +0100	[thread overview]
Message-ID: <1290688232-25142-5-git-send-email-jonas@southpole.se> (raw)
In-Reply-To: <1290688232-25142-1-git-send-email-jonas@southpole.se>

An interrupt may occur between checking bd.stat and clearing the
interrupt source register which would result in the packet going totally
unnoticed as the interrupt will be missed.  Double check bd.stat after
clearing the interrupt source register to guard against such an
occurrence.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
---
 drivers/net/ethoc.c |   15 +++++++++++++--
 1 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethoc.c b/drivers/net/ethoc.c
index db444a7..a12a07e 100644
--- a/drivers/net/ethoc.c
+++ b/drivers/net/ethoc.c
@@ -414,8 +414,19 @@ static int ethoc_rx(struct net_device *dev, int limit)
 
 		entry = priv->num_tx + (priv->cur_rx % priv->num_rx);
 		ethoc_read_bd(priv, entry, &bd);
-		if (bd.stat & RX_BD_EMPTY)
-			break;
+		if (bd.stat & RX_BD_EMPTY) {
+			ethoc_ack_irq(priv, INT_MASK_RX);
+			/* If packet (interrupt) came in between checking
+			 * BD_EMTPY and clearing the interrupt source, then we
+			 * risk missing the packet as the RX interrupt won't
+			 * trigger right away when we reenable it; hence, check
+			 * BD_EMTPY here again to make sure there isn't such a
+			 * packet waiting for us...
+			 */
+			ethoc_read_bd(priv, entry, &bd);
+			if (bd.stat & RX_BD_EMPTY)
+				break;
+		}
 
 		if (ethoc_update_rx_stats(priv, &bd) == 0) {
 			int size = bd.stat >> 16;
-- 
1.7.1


  parent reply	other threads:[~2010-11-25 12:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25 12:30 ethoc driver changes (version 2) Jonas Bonn
2010-11-25 12:30 ` [PATCH 1/8] ethoc: Add device tree configuration Jonas Bonn
2010-11-25 12:30 ` [PATCH 2/8] ethoc: remove unused spinlock Jonas Bonn
2010-11-25 12:30 ` [PATCH 3/8] ethoc: enable interrupts after napi_complete Jonas Bonn
2010-11-25 12:30 ` Jonas Bonn [this message]
2010-11-25 12:30 ` [PATCH 5/8] ethoc: rework interrupt handling Jonas Bonn
2010-11-25 12:30 ` [PATCH 6/8] ethoc: rework mdio read/write Jonas Bonn
2010-11-25 12:30 ` [PATCH 7/8] ethoc: fix function return type Jonas Bonn
2010-11-25 12:30 ` [PATCH 8/8] ethoc: remove division from loops Jonas Bonn
2010-11-28 19:17 ` ethoc driver changes (version 2) David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290688232-25142-5-git-send-email-jonas@southpole.se \
    --to=jonas@southpole.se \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).