From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org,
Linus Torvalds <torvalds@osdl.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 2/2] The new jhash implementation
Date: Thu, 25 Nov 2010 15:05:46 +0100 [thread overview]
Message-ID: <1290693946.2858.323.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTi=jqRY18Omv2Y2a1XjT-SH8W--wJ7A4y4PV1oT1@mail.gmail.com>
Le jeudi 25 novembre 2010 à 21:55 +0800, Changli Gao a écrit :
> > I suggest :
> >
> > #include <linux/unaligned/packed_struct.h>
> > ...
> > a += __get_unaligned_cpu32(k);
> > b += __get_unaligned_cpu32(k+4);
> > c += __get_unaligned_cpu32(k+8);
> >
> > Fits nicely in registers.
> >
>
> I think you mean get_unaligned_le32().
>
No, I meant __get_unaligned_cpu32()
We do same thing in jhash2() :
a += k[0];
b += k[1];
c += k[2];
We dont care of bit order of the 32bit quantity we are adding to a,b or
c , as long its consistent for the current machine ;)
get_unaligned_le32() would be slow on big endian arches.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-25 14:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 13:15 [PATCH 0/2] New jhash function Jozsef Kadlecsik
2010-11-25 13:15 ` [PATCH 1/2] Prepare the tree for un-inlined jhash Jozsef Kadlecsik
2010-11-25 13:15 ` [PATCH 2/2] The new jhash implementation Jozsef Kadlecsik
2010-11-25 13:49 ` Eric Dumazet
2010-11-25 13:55 ` Changli Gao
2010-11-25 14:05 ` Eric Dumazet [this message]
2010-11-25 14:41 ` Jozsef Kadlecsik
2010-11-25 17:21 ` Eric Dumazet
2010-11-25 21:14 ` Jozsef Kadlecsik
2010-11-27 3:31 ` Rusty Russell
2010-12-03 12:38 ` [PATCH 0/2] New jhash function Jozsef Kadlecsik
2010-12-03 12:39 ` [PATCH 1/2] Remove calls to jhash internals Jozsef Kadlecsik
2010-12-03 12:39 ` [PATCH 2/2] The new jhash implementation Jozsef Kadlecsik
2010-12-08 17:09 ` [PATCH 0/2] New jhash function David Miller
2010-12-08 21:23 ` Rusty Russell
2010-12-10 4:19 ` David Miller
2010-11-25 13:39 ` [PATCH 1/2] Prepare the tree for un-inlined jhash Jan Engelhardt
2010-11-25 13:57 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290693946.2858.323.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox