* [PATCH] cxgb3: Removing unused return variable
@ 2010-11-25 17:53 leitao
2010-11-28 19:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: leitao @ 2010-11-25 17:53 UTC (permalink / raw)
To: divy; +Cc: netdev, Breno Leitao
Currently the ret variable is not used for anything other than
receive the value of the t3_adapter_error(), which will always be 0,
because the reset parameter is 0.
Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
---
drivers/net/cxgb3/cxgb3_main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 046d846..3864617 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -3006,12 +3006,11 @@ static pci_ers_result_t t3_io_error_detected(struct pci_dev *pdev,
pci_channel_state_t state)
{
struct adapter *adapter = pci_get_drvdata(pdev);
- int ret;
if (state == pci_channel_io_perm_failure)
return PCI_ERS_RESULT_DISCONNECT;
- ret = t3_adapter_error(adapter, 0, 0);
+ t3_adapter_error(adapter, 0, 0);
/* Request a slot reset. */
return PCI_ERS_RESULT_NEED_RESET;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cxgb3: Removing unused return variable
2010-11-25 17:53 [PATCH] cxgb3: Removing unused return variable leitao
@ 2010-11-28 19:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-11-28 19:50 UTC (permalink / raw)
To: leitao; +Cc: divy, netdev
From: leitao@linux.vnet.ibm.com
Date: Thu, 25 Nov 2010 15:53:55 -0200
> Currently the ret variable is not used for anything other than
> receive the value of the t3_adapter_error(), which will always be 0,
> because the reset parameter is 0.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
Applied to net-next-2.6, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-28 19:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-25 17:53 [PATCH] cxgb3: Removing unused return variable leitao
2010-11-28 19:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).