From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH] net/r8169: Correct the ram code for RTL8111D(L) Date: Fri, 26 Nov 2010 23:12:26 +0000 Message-ID: <1290813146.3051.58.camel@localhost> References: <1290772470-23713-1-git-send-email-hayeswang@realtek.com> <1290779458.3051.45.camel@localhost> <20101126224914.GA12266@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-0N5UtheoqsfLlaIwWQbw" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller , 564628@bugs.debian.org To: Francois Romieu , Hayes Wang Return-path: In-Reply-To: <20101126224914.GA12266@electric-eye.fr.zoreil.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --=-0N5UtheoqsfLlaIwWQbw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2010-11-26 at 23:49 +0100, Francois Romieu wrote: > Ben Hutchings : > > On Fri, 2010-11-26 at 19:54 +0800, Hayes Wang wrote: > > > Correct the binary code (Low pass filter & DLY_CAP fine tune from uC)= . > > > The incorrect ram code would make the nic working abnormally. > > [...] > >=20 > > I'm glad you finally acknowledge that this is code rather than simple > > register initialisation. >=20 > I am not sure that Hayes is a native english speaker. >=20 > I am glad to see him posting here. Right. Hayes, by 'you' I meant Realtek, not you personally. If my reply seemed aggressive, I apologise. > [...] > > Below are the changes Debian currently applies in preparation for prope= r > > licencing of the firmware. >=20 > Do you have some scripts to convert the data at hand ? [...] No, it's easy enough to convert a single array by copying it into a C file that dumps it to stdout (assuming the file's byte order is defined to match your own machine). It might be worth adding some sort of header with a version and checksum. Your choice, really. Ben. --=20 Ben Hutchings, Debian Developer and kernel team member --=-0N5UtheoqsfLlaIwWQbw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIVAwUATPA+0Oe/yOyVhhEJAQLNwRAAgOm8Uoz8rBF9u3PhENbpG8YtowPLm5dH FGRHbq813V0/mmdbwXSE60OZf/LWuXTuab7GtLKPuqxH6j0tcjVE/bIczs47zxEO qrCZoxAvOTbD0i8clPgpbrpjhoVaEWCYcGdKPQieiNvdnhvLoZcM/OQOr4DyRiYU kN8O2LBw47NbQrpzqX1FFWQJXpk/Sb/IyHw3KjNXGv3loqT5cifXzroviQfXDHA1 R/ehFejAdhdBbpSiuDA0pzoTVSjjYQQVIdGg2PnwDypNxf0yhVXkw/o4dVy+T6YE Y5Qpep48OxLJEfdN9IEDYSWb8SiUEX/rz6P0Nf8HdiNdyIw8yPHXtuLw6rA3Sd2k MPS2zz/wregYa6PUXxTEQPLJ/GEq7TqG1VAxap49PdwmNY+wZ0wmqkQrgmylTi7N ppR2KllB6CMzx4l1l9s5qsnVKaDKqFqZ4/bgZaiA93034nOg2whYVy/fpJwe1zWC RHiaq985kqWSxVbXbXyJV1djuptEi5hJBzbe0YX5zGgtpWYpp0sNXe3xYOmV6DAR 8e3Jso6f0CRaKRmuDPL8i8NubLacijT2/ii55dwgca+S/9TwjgqBSm+/VUSNRU+5 pgckoA6R2mLTuzddAK64twGQZz3ss3V/Hj/vXqNkL76JqwhRLO0ftFzMjbWqPZGJ X59z3NqN4mE= =wgUx -----END PGP SIGNATURE----- --=-0N5UtheoqsfLlaIwWQbw--