From: Szymon Janc <szymon@janc.net.pl>
To: netdev@vger.kernel.org
Cc: Szymon Janc <szymon@janc.net.pl>
Subject: [PATCH 6/6] forcedeth: use usleep_range not msleep for small sleeps
Date: Sat, 27 Nov 2010 19:39:48 +0100 [thread overview]
Message-ID: <1290883188-2078-7-git-send-email-szymon@janc.net.pl> (raw)
In-Reply-To: <1290883188-2078-1-git-send-email-szymon@janc.net.pl>
Signed-off-by: Szymon Janc <szymon@janc.net.pl>
---
drivers/net/forcedeth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index a2b6681..538bd9b 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -1178,7 +1178,7 @@ static int phy_reset(struct net_device *dev, u32 bmcr_setup)
/* must wait till reset is deasserted */
while (miicontrol & BMCR_RESET) {
- msleep(10);
+ usleep_range(10000, 20000);
miicontrol = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
/* FIXME: 100 tries seem excessive */
if (tries++ > 100)
--
1.7.2.3
next prev parent reply other threads:[~2010-11-27 18:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 18:39 [PATCH 0/6] Forcedeth code style cleanup Szymon Janc
2010-11-27 18:39 ` [PATCH 1/6] forcedeth: fix multiple code style issues Szymon Janc
2010-11-27 18:39 ` [PATCH 2/6] forcedeth: remove unnecessary checks before kfree Szymon Janc
2010-11-27 18:39 ` [PATCH 3/6] forcedeth: include <linux/io.h> and <linux/uaccess.h> instead of <asm/io.h> and <asm/uaccess.h> as suggested by checkpatch Szymon Janc
2010-11-27 18:39 ` [PATCH 4/6] forcedeth: do not use assignment in if conditions Szymon Janc
2010-11-27 18:39 ` [PATCH 5/6] forcedeth: use KERN_ facility level in printk Szymon Janc
2010-11-27 19:04 ` Ben Hutchings
2010-11-27 19:45 ` Joe Perches
2010-11-28 9:05 ` Michał Mirosław
2010-11-28 9:11 ` Joe Perches
2010-11-27 18:39 ` Szymon Janc [this message]
2010-11-29 2:07 ` [PATCH 0/6] Forcedeth code style cleanup David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290883188-2078-7-git-send-email-szymon@janc.net.pl \
--to=szymon@janc.net.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).