From: Maxim Levitsky <maximlevitsky@gmail.com>
To: linux1394-devel <linux1394-devel@lists.sourceforge.net>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
netdev@vger.kernel.org, Maxim Levitsky <maximlevitsky@gmail.com>
Subject: [PATCH 1/5] firewire: ohci: restore GUID register on resume.
Date: Sun, 28 Nov 2010 03:15:32 +0200 [thread overview]
Message-ID: <1290906936-14472-2-git-send-email-maximlevitsky@gmail.com> (raw)
In-Reply-To: <1290906936-14472-1-git-send-email-maximlevitsky@gmail.com>
Some lousy BIOSes, eg my Aspire 5720 BIOS forgets to restore
device GUID on resume from ram.
Fix that by programming GUID register on resume from ram
Since that register is one time programable according to spec,
that has no effect on systems that have sane BIOS (Are there any?)
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
drivers/firewire/ohci.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
index 6dd56cd..cadd6af 100644
--- a/drivers/firewire/ohci.c
+++ b/drivers/firewire/ohci.c
@@ -3240,6 +3240,10 @@ static int pci_resume(struct pci_dev *dev)
return err;
}
+ /* Some bioses forget to reinitialize the GUID. Do that ourselves */
+ reg_write(ohci, OHCI1394_GUIDLo, ohci->card.guid & 0xFFFFFFFF);
+ reg_write(ohci, OHCI1394_GUIDHi, (ohci->card.guid >> 32) & 0xFFFFFFFF);
+
return ohci_enable(&ohci->card, NULL, 0);
}
#endif
--
1.7.1
next prev parent reply other threads:[~2010-11-28 1:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 1:15 [PATCH 0/5] Firewire networking assorted fixes Maxim Levitsky
2010-11-28 1:15 ` Maxim Levitsky [this message]
2010-11-28 1:15 ` [PATCH 2/5] firewire: ohci: restart ISO channels on resume Maxim Levitsky
2010-11-28 1:15 ` [PATCH 3/5] NET: ARP: allow to invalidate specific ARP entries Maxim Levitsky
2010-11-28 1:15 ` [PATCH 4/5] firewire: net: invalidate ARP entries for removed nodes Maxim Levitsky
2010-11-28 1:15 ` [PATCH 5/5] firewire: net: ratelimit error messages Maxim Levitsky
2010-11-28 3:02 ` [PATCH 0/5] Firewire networking assorted fixes Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290906936-14472-2-git-send-email-maximlevitsky@gmail.com \
--to=maximlevitsky@gmail.com \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).