From: Joe Perches <joe@perches.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Szymon Janc <szymon@janc.net.pl>,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/6] forcedeth: use KERN_ facility level in printk
Date: Sun, 28 Nov 2010 01:11:43 -0800 [thread overview]
Message-ID: <1290935503.16349.7.camel@Joe-Laptop> (raw)
In-Reply-To: <AANLkTi=X-4mg2SyKx870B1xN4uW+4NPuPL=Fv_cqYf--@mail.gmail.com>
On Sun, 2010-11-28 at 10:05 +0100, Michał Mirosław wrote:
> 2010/11/27 Joe Perches <joe@perches.com>:
> > On Sat, 2010-11-27 at 19:04 +0000, Ben Hutchings wrote:
> >> On Sat, 2010-11-27 at 19:39 +0100, Szymon Janc wrote:
> >> > diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> >> > index 2f092d7..a2b6681 100644
> >> > @@ -958,7 +958,7 @@ static int reg_delay(struct net_device *dev, int offset, u32 mask, u32 target,
[]
> >> > - printk("%s", msg);
> >> > + printk(KERN_WARNING "%s", msg);
> >> No, msg already includes a log level.
> > True. The messages are still broken though.
> > Some have trailing newlines, others not.
> > It'd be better to move the msg after the reg_delay
> > call and add the missing newlines.
> [...]
> > diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> > @@ -1547,9 +1544,9 @@ static void nv_stop_rx(struct net_device *dev)
[]
> > - reg_delay(dev, NvRegReceiverStatus, NVREG_RCVSTAT_BUSY, 0,
> > - NV_RXSTOP_DELAY1, NV_RXSTOP_DELAY1MAX,
> > - KERN_INFO "nv_stop_rx: ReceiverStatus remained busy");
> > + if (reg_delay(dev, NvRegReceiverStatus, NVREG_RCVSTAT_BUSY, 0,
> > + NV_RXSTOP_DELAY1, NV_RXSTOP_DELAY1MAX))
> > + printk(KERN_INFO "nv_stop_rx: ReceiverStatus remained busy\n");
> You could change it to dev_info() and friends in one go.
Yeah, I did that in a local tree for all logging calls,
(dprintk->netdev_dbg, printk->netdev_<level> etc) but I'll
wait until Szymon's patches are applied or nacked.
next prev parent reply other threads:[~2010-11-28 9:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 18:39 [PATCH 0/6] Forcedeth code style cleanup Szymon Janc
2010-11-27 18:39 ` [PATCH 1/6] forcedeth: fix multiple code style issues Szymon Janc
2010-11-27 18:39 ` [PATCH 2/6] forcedeth: remove unnecessary checks before kfree Szymon Janc
2010-11-27 18:39 ` [PATCH 3/6] forcedeth: include <linux/io.h> and <linux/uaccess.h> instead of <asm/io.h> and <asm/uaccess.h> as suggested by checkpatch Szymon Janc
2010-11-27 18:39 ` [PATCH 4/6] forcedeth: do not use assignment in if conditions Szymon Janc
2010-11-27 18:39 ` [PATCH 5/6] forcedeth: use KERN_ facility level in printk Szymon Janc
2010-11-27 19:04 ` Ben Hutchings
2010-11-27 19:45 ` Joe Perches
2010-11-28 9:05 ` Michał Mirosław
2010-11-28 9:11 ` Joe Perches [this message]
2010-11-27 18:39 ` [PATCH 6/6] forcedeth: use usleep_range not msleep for small sleeps Szymon Janc
2010-11-29 2:07 ` [PATCH 0/6] Forcedeth code style cleanup David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290935503.16349.7.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bhutchings@solarflare.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox