From: "Vladislav Zolotarov" <vladz@broadcom.com>
To: "Eric Dumazet" <eric.dumazet@gmail.com>
Cc: "Dave Miller" <davem@davemloft.net>,
"Eilon Greenstein" <eilong@broadcom.com>,
"netdev list" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] bnx2x: Use skb_is_gso_v6(skb) instead of accessing the skb_shinfo(skb) directly
Date: Sun, 28 Nov 2010 12:22:14 +0200 [thread overview]
Message-ID: <1290939734.21703.78.camel@lb-tlvb-vladz> (raw)
In-Reply-To: <1290851625.2794.17.camel@edumazet-laptop>
>
> May I ask why ?
>
> This seems not consistent with the previous block.
>
> Either you also add a skb_is_gso_v4(skb) helper, or let the code as is,
> maybe reordering the flags ?
>
U r right. I'm respinning a patch taking your remarks and a "brackets"
patch into an account.
thanks, Eric.
next prev parent reply other threads:[~2010-11-28 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 15:21 [PATCH net-next] bnx2x: Do interrupt mode initialization and NAPIs adding before register_netdev() Vladislav Zolotarov
2010-11-24 19:10 ` David Miller
2010-11-25 9:52 ` [PATCH net-next] bnx2x: Use skb_is_gso_v6(skb) instead of accessing the skb_shinfo(skb) directly Vladislav Zolotarov
2010-11-27 9:53 ` Eric Dumazet
2010-11-28 10:22 ` Vladislav Zolotarov [this message]
2010-11-28 10:23 ` [PATCH net-next] bnx2x: Use helpers instead of direct access to the shinfo(skb) fields Vladislav Zolotarov
2010-11-28 19:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290939734.21703.78.camel@lb-tlvb-vladz \
--to=vladz@broadcom.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox