From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
Nagendra Tomar <tomer_iisc@yahoo.com>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net-next: Fix __inet_inherit_port() to correctly increment bsockets and num_owners
Date: Mon, 29 Nov 2010 14:17:46 +0100 [thread overview]
Message-ID: <1291036666.3435.435.camel@edumazet-laptop> (raw)
In-Reply-To: <20101129131201.GB9286@ff.dom.local>
Le lundi 29 novembre 2010 à 13:12 +0000, Jarek Poplawski a écrit :
> Evgeniy & Eric,
>
> But it's compared to the numer of available port numbers in
> inet_csk_get_port():
>
> "if (atomic_read(&hashinfo->bsockets) > (high - low) + 1)"
>
> Can't you have bsockets higher than this with only one port used?
>
Because we store tuples, not only port information.
You can have many sockets bound on a single port.
This 'optimization' was only meaningful on a machine you make only
active connections, if you ask me...
Problem is, as soon as some passive connections are done, bsockets count
becomes wrong. The patch fixes this, thats all.
next prev parent reply other threads:[~2010-11-29 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 0:26 [PATCH] net-next: Fix __inet_inherit_port() to correctly increment bsockets and num_owners Nagendra Tomar
2010-11-27 9:02 ` Eric Dumazet
2010-11-28 23:00 ` Evgeniy Polyakov
2010-11-29 2:20 ` David Miller
2010-11-29 12:39 ` Jarek Poplawski
2010-11-29 12:49 ` Eric Dumazet
2010-11-29 12:51 ` Evgeniy Polyakov
2010-11-29 13:12 ` Jarek Poplawski
2010-11-29 13:17 ` Eric Dumazet [this message]
2010-11-29 13:33 ` Jarek Poplawski
-- strict thread matches above, loose matches on Subject: below --
2010-11-26 10:47 [PATCH] net: " Eric Dumazet
2010-11-27 0:01 ` [PATCH] net-next: " Nagendra Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291036666.3435.435.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tomer_iisc@yahoo.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox