netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, allan.stephens@windriver.com
Subject: [PATCH net-next 04/11] tipc: Eliminate useless return value when disabling a bearer
Date: Tue, 30 Nov 2010 17:00:56 -0500	[thread overview]
Message-ID: <1291154463-26346-5-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1291154463-26346-1-git-send-email-paul.gortmaker@windriver.com>

From: Allan Stephens <Allan.Stephens@windriver.com>

Modifies bearer_disable() to return void since it always indicates
success anyway.

Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 net/tipc/bearer.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index 347f255..885da94 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -622,7 +622,7 @@ int tipc_block_bearer(const char *name)
  * Note: This routine assumes caller holds tipc_net_lock.
  */
 
-static int bearer_disable(struct bearer *b_ptr)
+static void bearer_disable(struct bearer *b_ptr)
 {
 	struct link *l_ptr;
 	struct link *temp_l_ptr;
@@ -638,7 +638,6 @@ static int bearer_disable(struct bearer *b_ptr)
 	}
 	spin_unlock_bh(&b_ptr->publ.lock);
 	memset(b_ptr, 0, sizeof(struct bearer));
-	return 0;
 }
 
 int tipc_disable_bearer(const char *name)
@@ -651,8 +650,10 @@ int tipc_disable_bearer(const char *name)
 	if (b_ptr == NULL) {
 		warn("Attempt to disable unknown bearer <%s>\n", name);
 		res = -EINVAL;
-	} else
-		res = bearer_disable(b_ptr);
+	} else {
+		bearer_disable(b_ptr);
+		res = 0;
+	}
 	write_unlock_bh(&tipc_net_lock);
 	return res;
 }
-- 
1.7.3.2.146.g2d444


  parent reply	other threads:[~2010-11-30 22:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 22:00 [PATCH 0/11 net-next] TIPC cleanups for native API removal Paul Gortmaker
2010-11-30 22:00 ` [PATCH net-next 01/11] tipc: Remove obsolete native API files and exports Paul Gortmaker
2010-11-30 22:00 ` [PATCH net-next 02/11] tipc: Remove obsolete inclusions of header files Paul Gortmaker
2010-11-30 22:00 ` [PATCH net-next 03/11] tipc: Delete unused configuration service structure definition Paul Gortmaker
2010-11-30 22:00 ` Paul Gortmaker [this message]
2010-11-30 22:00 ` [PATCH net-next 05/11] tipc: Delete useless function prototypes Paul Gortmaker
2010-11-30 22:00 ` [PATCH net-next 06/11] tipc: Remove support for TIPC mode change callback Paul Gortmaker
2010-11-30 22:00 ` [PATCH net-next 07/11] tipc: Remove unused domain argument from multicast send routine Paul Gortmaker
2010-11-30 22:01 ` [PATCH net-next 08/11] tipc: Eliminate useless initialization when creating subscriber Paul Gortmaker
2010-11-30 22:01 ` [PATCH net-next 09/11] tipc: Eliminate an unused symbolic constant in link code Paul Gortmaker
2010-11-30 22:01 ` [PATCH net-next 10/11] tipc: Eliminate obsolete native API forwarding routines Paul Gortmaker
2010-11-30 22:01 ` [PATCH net-next 11/11] tipc: Delete tipc_ownidentity() Paul Gortmaker
2010-12-02 21:34 ` [PATCH 0/11 net-next] TIPC cleanups for native API removal David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291154463-26346-5-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=allan.stephens@windriver.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).