Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: xiaosuo@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: don't reallocate skb->head unless the current one hasn't the needed extra size or is shared
Date: Fri, 03 Dec 2010 19:01:39 +0100	[thread overview]
Message-ID: <1291399299.2897.572.camel@edumazet-laptop> (raw)
In-Reply-To: <20101203.094739.35049271.davem@davemloft.net>

Le vendredi 03 décembre 2010 à 09:47 -0800, David Miller a écrit :
> From: Changli Gao <xiaosuo@gmail.com>
> Date: Tue, 30 Nov 2010 16:48:46 +0800
> 
> > skb head being allocated by kmalloc(), it might be larger than what
> > actually requested because of discrete kmem caches sizes. Before
> > reallocating a new skb head, check if the current one has the needed
> > extra size.
> > 
> > Do this check only if skb head is not shared.
> > 
> > Signed-off-by: Changli Gao <xiaosuo@gmail.com>
> > Cc: Eric Dumazet <eric.dumazet@gmail.com>
> 
> Eric, ACK?

Yes :)

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

Thanks !



      reply	other threads:[~2010-12-03 18:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30  8:48 [PATCH v3] net: don't reallocate skb->head unless the current one hasn't the needed extra size or is shared Changli Gao
2010-12-03 17:47 ` David Miller
2010-12-03 18:01   ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291399299.2897.572.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox