* [PATCH net-2.6] cxgb4: fix MAC address hash filter
@ 2010-12-03 20:39 Dimitris Michailidis
2010-12-08 17:36 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dimitris Michailidis @ 2010-12-03 20:39 UTC (permalink / raw)
To: netdev
Fix the calculation of the inexact hash-based MAC address filter.
It's 64 bits but current code is missing a ULL. Results in filtering out
some legitimate packets.
Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
---
drivers/net/cxgb4/t4_hw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb4/t4_hw.c b/drivers/net/cxgb4/t4_hw.c
index bb813d9..e97521c 100644
--- a/drivers/net/cxgb4/t4_hw.c
+++ b/drivers/net/cxgb4/t4_hw.c
@@ -2408,7 +2408,7 @@ int t4_alloc_mac_filt(struct adapter *adap, unsigned int mbox,
if (index < NEXACT_MAC)
ret++;
else if (hash)
- *hash |= (1 << hash_mac_addr(addr[i]));
+ *hash |= (1ULL << hash_mac_addr(addr[i]));
}
return ret;
}
--
1.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-2.6] cxgb4: fix MAC address hash filter
2010-12-03 20:39 [PATCH net-2.6] cxgb4: fix MAC address hash filter Dimitris Michailidis
@ 2010-12-08 17:36 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-12-08 17:36 UTC (permalink / raw)
To: dm; +Cc: netdev
From: Dimitris Michailidis <dm@chelsio.com>
Date: Fri, 3 Dec 2010 12:39:04 -0800
> Fix the calculation of the inexact hash-based MAC address filter.
> It's 64 bits but current code is missing a ULL. Results in filtering out
> some legitimate packets.
>
> Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-08 17:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-03 20:39 [PATCH net-2.6] cxgb4: fix MAC address hash filter Dimitris Michailidis
2010-12-08 17:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).