From: Changli Gao <xiaosuo@gmail.com>
To: jamal <hadi@cyberus.ca>
Cc: netdev@vger.kernel.org, jamal <hadi@cyberus.ca>,
Changli Gao <xiaosuo@gmail.com>
Subject: [PATCH 1/3] ifb: remove the useless debug stats
Date: Sat, 4 Dec 2010 13:55:19 +0800 [thread overview]
Message-ID: <1291442121-3302-1-git-send-email-xiaosuo@gmail.com> (raw)
These debug stats are not exported, and become useless.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
drivers/net/ifb.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index ab9f675..4387525 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -42,16 +42,6 @@
struct ifb_private {
struct tasklet_struct ifb_tasklet;
int tasklet_pending;
- /* mostly debug stats leave in for now */
- unsigned long st_task_enter; /* tasklet entered */
- unsigned long st_txq_refl_try; /* transmit queue refill attempt */
- unsigned long st_rxq_enter; /* receive queue entered */
- unsigned long st_rx2tx_tran; /* receive to trasmit transfers */
- unsigned long st_rxq_notenter; /*receiveQ not entered, resched */
- unsigned long st_rx_frm_egr; /* received from egress path */
- unsigned long st_rx_frm_ing; /* received from ingress path */
- unsigned long st_rxq_check;
- unsigned long st_rxq_rsch;
struct sk_buff_head rq;
struct sk_buff_head tq;
};
@@ -73,19 +63,14 @@ static void ri_tasklet(unsigned long dev)
struct sk_buff *skb;
txq = netdev_get_tx_queue(_dev, 0);
- dp->st_task_enter++;
if ((skb = skb_peek(&dp->tq)) == NULL) {
- dp->st_txq_refl_try++;
if (__netif_tx_trylock(txq)) {
- dp->st_rxq_enter++;
while ((skb = skb_dequeue(&dp->rq)) != NULL) {
skb_queue_tail(&dp->tq, skb);
- dp->st_rx2tx_tran++;
}
__netif_tx_unlock(txq);
} else {
/* reschedule */
- dp->st_rxq_notenter++;
goto resched;
}
}
@@ -110,10 +95,8 @@ static void ri_tasklet(unsigned long dev)
skb->skb_iif = _dev->ifindex;
if (from & AT_EGRESS) {
- dp->st_rx_frm_egr++;
dev_queue_xmit(skb);
} else if (from & AT_INGRESS) {
- dp->st_rx_frm_ing++;
skb_pull(skb, skb->dev->hard_header_len);
netif_rx(skb);
} else
@@ -121,13 +104,11 @@ static void ri_tasklet(unsigned long dev)
}
if (__netif_tx_trylock(txq)) {
- dp->st_rxq_check++;
if ((skb = skb_peek(&dp->rq)) == NULL) {
dp->tasklet_pending = 0;
if (netif_queue_stopped(_dev))
netif_wake_queue(_dev);
} else {
- dp->st_rxq_rsch++;
__netif_tx_unlock(txq);
goto resched;
}
next reply other threads:[~2010-12-04 5:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 5:55 Changli Gao [this message]
2010-12-04 5:55 ` [PATCH 2/3] ifb: remove unused macro TX_TIMEOUT Changli Gao
2010-12-04 14:13 ` jamal
2010-12-04 5:55 ` [PATCH 3/3] ifb: move tq from ifb_private Changli Gao
2010-12-04 13:15 ` Jarek Poplawski
2010-12-04 13:29 ` Changli Gao
2010-12-04 14:28 ` jamal
2010-12-04 14:45 ` Changli Gao
2010-12-04 14:55 ` jamal
2010-12-04 15:01 ` Changli Gao
2010-12-04 15:09 ` jamal
2010-12-04 14:48 ` jamal
2010-12-04 15:40 ` Jarek Poplawski
2010-12-04 16:08 ` jamal
2010-12-04 16:56 ` Jarek Poplawski
2010-12-05 0:22 ` Changli Gao
2010-12-05 1:13 ` Changli Gao
2010-12-05 14:30 ` jamal
2010-12-05 14:40 ` Changli Gao
2010-12-05 15:13 ` Eric Dumazet
2010-12-05 15:16 ` Changli Gao
2010-12-05 15:13 ` jamal
2010-12-05 15:22 ` Changli Gao
2010-12-05 15:31 ` jamal
2010-12-05 14:27 ` jamal
2010-12-05 19:09 ` Jarek Poplawski
2010-12-04 14:18 ` jamal
2010-12-04 14:20 ` Changli Gao
2010-12-04 14:42 ` jamal
2010-12-04 14:50 ` Changli Gao
2010-12-04 14:59 ` jamal
2010-12-04 15:07 ` Changli Gao
2010-12-04 15:11 ` jamal
2010-12-04 14:12 ` [PATCH 1/3] ifb: remove the useless debug stats jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291442121-3302-1-git-send-email-xiaosuo@gmail.com \
--to=xiaosuo@gmail.com \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).