From: David Brownell <david-b@pacbell.net>
To: Indrek Peri <Indrek.Peri@Ericsson.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Insert interrupt URB after resume, so that status transfers can flow.
Date: Mon, 06 Dec 2010 18:57:54 -0800 [thread overview]
Message-ID: <1291690674.2285.229.camel@helium> (raw)
In-Reply-To: <1291630983-23725-1-git-send-email-Indrek.Peri@Ericsson.com>
Building on my comment about your other patch ... shouldn't this be just
another part of the "resume driver" action,
like refilling the RX urb queue?
For the same reasons ... NAK. It looks like the work to add suspend and
resume processing to this driver had a few holes, and resume handling
can be simplified by combining re-activation of RX processing and this
status reporting (where relevant) in one routine.
- Dave
prev parent reply other threads:[~2010-12-07 2:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 10:23 [PATCH] Insert interrupt URB after resume, so that status transfers can flow Indrek Peri
2010-12-07 2:57 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291690674.2285.229.camel@helium \
--to=david-b@pacbell.net \
--cc=Indrek.Peri@Ericsson.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).