From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [34/44] Limit sysctl_tcp_mem and sysctl_udp_mem initializers to prevent integer overflows. Date: Wed, 08 Dec 2010 06:50:45 +0100 Message-ID: <1291787445.5324.64.camel@edumazet-laptop> References: <20101208003205.GA4286@kroah.com> <20101208000642.975564500@clark.site> <20101208041656.GA2291@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Linus Torvalds , linux-kernel@vger.kernel.org, stable@kernel.org, "David S. Miller" , stable-review@kernel.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Robin Holt , Willy Tarreau , netdev@vger.kernel.org, linux-sctp@vger.kernel.org, Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Vlad Yasevich , Sridhar Samudrala To: Greg KH Return-path: In-Reply-To: <20101208041656.GA2291@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Le mardi 07 d=C3=A9cembre 2010 =C3=A0 20:16 -0800, Greg KH a =C3=A9crit= : > On Tue, Dec 07, 2010 at 05:22:34PM -0800, Linus Torvalds wrote: > > On Tue, Dec 7, 2010 at 4:04 PM, Greg KH wrote: > > > > > > From: Robin Holt > > > > > > [ Problem was fixed differently upstream. -DaveM ] > >=20 > > Gaah. I'd really like to see more of a description for things like > > this. A commit ID for the alternate fix, or at least a few words ab= out > > the different fix or reason why upstream doesn't need the stable > > commit. >=20 > I'll let David confirm this, he's the one who sent it to me :) upstream uses commit 8d987e5c7510 (net: avoid limits overflow) This commit is a bit more untrusive for stable kernels : It depends on : a9febbb4bd13 (sysctl: min/max bounds are optional) 27b3d80a7b6a (sysctl: fix min/max handling in __do_proc_doulongvec_minm= ax())