From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Govindarajan, Sriramakrishnan" <srk@ti.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Adding Support for SG,GSO,GRO
Date: Thu, 09 Dec 2010 11:50:16 +0100 [thread overview]
Message-ID: <1291891816.4063.5.camel@edumazet-laptop> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC356087035F21D9F9@dbde02.ent.ti.com>
Le jeudi 09 décembre 2010 à 16:03 +0530, Govindarajan, Sriramakrishnan a
écrit :
> Hi
> We have a NAPI compliant driver(net/drivers/davinci_emac.c), that does well at 10/100Mbps loads. Now the same controller/driver is used for 1000Mbps
> mode as well, where the CPU gets saturated easily
>
> Internally the module supports scatter gather DMA(which is currently not
> exercised) but there is no HW checksum support.
>
> To specifically implement GRO, GSO support would it be sufficient to add
> SG support to the driver? Are there other means of increasing the throughput
> and decreasing the CPU loading?
>
> Any pointers to reference implementation for adding SG/GRO/GSO support will be helpful.
Adding GRO is pretty easy, since you already are NAPI.
call
napi_gro_receive(&adapter->napi, skb)
instead of
netif_receive_skb(skb);
(
Take commit 6a08d194ee4080 as an example of such conversion
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=6a08d194ee40806e0ccd5f36ed768e64cbfc979f
next prev parent reply other threads:[~2010-12-09 10:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 10:33 Adding Support for SG,GSO,GRO Govindarajan, Sriramakrishnan
2010-12-09 10:50 ` Eric Dumazet [this message]
2010-12-09 14:49 ` Govindarajan, Sriramakrishnan
2010-12-09 15:02 ` Ben Hutchings
2010-12-09 18:29 ` David Miller
2010-12-09 18:47 ` Michał Mirosław
2010-12-09 18:58 ` Ben Hutchings
2010-12-10 8:27 ` Michał Mirosław
2010-12-09 19:38 ` David Miller
2010-12-10 14:18 ` Michał Mirosław
2010-12-10 14:31 ` David Lamparter
2010-12-10 16:01 ` Michał Mirosław
2010-12-10 16:20 ` Ben Hutchings
2010-12-10 18:05 ` David Miller
2010-12-10 16:23 ` David Lamparter
2010-12-10 16:26 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291891816.4063.5.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox