Re: [PATCH net-2.6] net/ipv6/udp.c: fix typo in flush_stack()

[Eric Dumazet <eric.dumazet@gmail.com>]

Le jeudi 09 décembre 2010 à 14:40 +0100, Jiri Pirko a écrit :
> skb1 should be passed as parameter to sk_rcvqueues_full() here.
> 
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
> 
> diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
> index 91def93..d2b268e 100644
> --- a/net/ipv6/udp.c
> +++ b/net/ipv6/udp.c
> @@ -602,7 +602,7 @@ static void flush_stack(struct sock **stack, unsigned int count,
>  
>  		sk = stack[i];
>  		if (skb1) {
> -			if (sk_rcvqueues_full(sk, skb)) {
> +			if (sk_rcvqueues_full(sk, skb1)) {
>  				kfree_skb(skb1);
>  				goto drop;
>  			}

net-2.6 ? Its the same truesize anyway...

So it's not a bug, but a cosmetic change.
(I am ok with it, but for net-next-2.6)

/*
 * Take into account size of receive queue and backlog queue
 */
static inline bool sk_rcvqueues_full(const struct sock *sk, const struct sk_buff *skb)
{
        unsigned int qsize = sk->sk_backlog.len + atomic_read(&sk->sk_rmem_alloc);

        return qsize + skb->truesize > sk->sk_rcvbuf;
}