From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, davem@davemleft.org,
Bruce Allan <bruce.w.allan@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com
Subject: Re: [net-next-2.6 25/27] e1000e: static analysis tools complain of a possible null ptr p dereference
Date: Fri, 10 Dec 2010 04:44:50 -0800 [thread overview]
Message-ID: <1291985090.24978.17.camel@Joe-Laptop> (raw)
In-Reply-To: <1291975585-30576-2-git-send-email-jeffrey.t.kirsher@intel.com>
On Fri, 2010-12-10 at 02:06 -0800, Jeff Kirsher wrote:
> diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c
[]
> + default:
> + data[i] = 0;
> + continue;
> + break;
Using
continue;
break;
is odd and unhelpful.
Just continue; is sufficient and clear.
next prev parent reply other threads:[~2010-12-10 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 10:06 [net-next-2.6 24/27] e1000e: minor error message corrections Jeff Kirsher
2010-12-10 10:06 ` [net-next-2.6 25/27] e1000e: static analysis tools complain of a possible null ptr p dereference Jeff Kirsher
2010-12-10 12:44 ` Joe Perches [this message]
2010-12-10 19:35 ` Tantilov, Emil S
2010-12-10 19:58 ` Joe Perches
2010-12-10 20:16 ` David Miller
2010-12-10 10:06 ` [net-next-2.6 26/27] e1000e: increment the driver version Jeff Kirsher
2010-12-10 10:06 ` [net-next-2.6 27/27] igb: Add new function to read part number from EEPROM in string format Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291985090.24978.17.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bphilips@novell.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemleft.org \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox