From: Tomoya MORINAGA <tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
To: wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
chripell-VaTbYqLCNhc@public.gmane.org,
21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TZUIDd8j+nm9g@public.gmane.org
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: [PATCH net-next-2.6 v9 13/20] pch_can: Fix bit timing calculation issue
Date: Mon, 13 Dec 2010 15:24:19 +0900 [thread overview]
Message-ID: <1292221467-8039-13-git-send-email-tomoya-linux@dsn.okisemi.com> (raw)
In-Reply-To: <1292221467-8039-12-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
Modify like use calculated value directly passed by CAN core module.
Signed-off-by: Tomoya MORINAGA <tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
Acked-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/net/can/pch_can.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c
index 3540978..5a6a0df 100644
--- a/drivers/net/can/pch_can.c
+++ b/drivers/net/can/pch_can.c
@@ -786,17 +786,15 @@ static int pch_set_bittiming(struct net_device *ndev)
const struct can_bittiming *bt = &priv->can.bittiming;
u32 canbit;
u32 bepe;
- u32 brp;
/* Setting the CCE bit for accessing the Can Timing register. */
pch_can_bit_set(&priv->regs->cont, PCH_CTRL_CCE);
- brp = (bt->tq) / (1000000000/PCH_CAN_CLK) - 1;
- canbit = brp & PCH_MSK_BITT_BRP;
+ canbit = (bt->brp - 1) & PCH_MSK_BITT_BRP;
canbit |= (bt->sjw - 1) << PCH_BIT_SJW_SHIFT;
canbit |= (bt->phase_seg1 + bt->prop_seg - 1) << PCH_BIT_TSEG1_SHIFT;
canbit |= (bt->phase_seg2 - 1) << PCH_BIT_TSEG2_SHIFT;
- bepe = (brp & PCH_MSK_BRPE_BRPE) >> PCH_BIT_BRPE_BRPE_SHIFT;
+ bepe = ((bt->brp - 1) & PCH_MSK_BRPE_BRPE) >> PCH_BIT_BRPE_BRPE_SHIFT;
iowrite32(canbit, &priv->regs->bitt);
iowrite32(bepe, &priv->regs->brpe);
pch_can_bit_clear(&priv->regs->cont, PCH_CTRL_CCE);
--
1.6.0.6
next prev parent reply other threads:[~2010-12-13 6:24 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 6:24 [PATCH net-next-2.6 v9 01/20] pch_can: Add flow control processing Tomoya MORINAGA
[not found] ` <1292221467-8039-1-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 02/20] pch_can: Divide poll function Tomoya MORINAGA
[not found] ` <1292221467-8039-2-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 03/20] pch_can: Fix endianness issue Tomoya MORINAGA
[not found] ` <1292221467-8039-3-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 04/20] pch_can: Improve rx processing Tomoya MORINAGA
[not found] ` <1292221467-8039-4-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 05/20] pch_can: Fix warnings Tomoya MORINAGA
[not found] ` <1292221467-8039-5-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 06/20] pch_can: Rename function/macro name Tomoya MORINAGA
[not found] ` <1292221467-8039-6-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 07/20] pch_can: Change functions type Tomoya MORINAGA
[not found] ` <1292221467-8039-7-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 08/20] pch_can: Reduce register access Tomoya MORINAGA
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 09/20] pch_can: Change Copyright and module description Tomoya MORINAGA
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 10/20] pch_can: Replace netdev_dbg instead of dev_dbg partly Tomoya MORINAGA
[not found] ` <1292221467-8039-10-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 11/20] pch_can: Fix coding rule violation Tomoya MORINAGA
[not found] ` <1292221467-8039-11-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 12/20] pch_can: Delete unnecessary/redundant code Tomoya MORINAGA
[not found] ` <1292221467-8039-12-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` Tomoya MORINAGA [this message]
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 14/20] pch_can: Fix miss-setting status issue Tomoya MORINAGA
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 15/20] pch_can: Comment optimization Tomoya MORINAGA
[not found] ` <1292221467-8039-15-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 16/20] pch_can: Move MSI processing to probe/remove processing Tomoya MORINAGA
[not found] ` <1292221467-8039-16-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 17/20] pch_can: Fix incorrect return processing Tomoya MORINAGA
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 18/20] pch_can: Optimize "if" condition in rx/tx processing Tomoya MORINAGA
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 19/20] pch_can: Add setting TEC/REC statistics processing Tomoya MORINAGA
2010-12-13 6:24 ` [PATCH net-next-2.6 v9 20/20] pch_can: Replace netif_rx to netif_receive_skb Tomoya MORINAGA
[not found] ` <1292221467-8039-20-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 20:28 ` David Miller
2010-12-13 21:51 ` Oliver Hartkopp
2010-12-14 3:45 ` David Miller
2010-12-14 2:16 ` Tomoya MORINAGA
[not found] ` <1292221467-8039-19-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 20:28 ` [PATCH net-next-2.6 v9 19/20] pch_can: Add setting TEC/REC statistics processing David Miller
[not found] ` <1292221467-8039-18-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 20:28 ` [PATCH net-next-2.6 v9 18/20] pch_can: Optimize "if" condition in rx/tx processing David Miller
[not found] ` <1292221467-8039-17-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 20:28 ` [PATCH net-next-2.6 v9 17/20] pch_can: Fix incorrect return processing David Miller
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 16/20] pch_can: Move MSI processing to probe/remove processing David Miller
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 15/20] pch_can: Comment optimization David Miller
[not found] ` <1292221467-8039-14-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 14/20] pch_can: Fix miss-setting status issue David Miller
[not found] ` <1292221467-8039-13-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 13/20] pch_can: Fix bit timing calculation issue David Miller
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 12/20] pch_can: Delete unnecessary/redundant code David Miller
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 11/20] pch_can: Fix coding rule violation David Miller
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 10/20] pch_can: Replace netdev_dbg instead of dev_dbg partly David Miller
[not found] ` <1292221467-8039-9-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 09/20] pch_can: Change Copyright and module description David Miller
[not found] ` <1292221467-8039-8-git-send-email-tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-12-13 20:27 ` [PATCH net-next-2.6 v9 08/20] pch_can: Reduce register access David Miller
2010-12-13 20:26 ` [PATCH net-next-2.6 v9 07/20] pch_can: Change functions type David Miller
2010-12-13 20:26 ` [PATCH net-next-2.6 v9 06/20] pch_can: Rename function/macro name David Miller
2010-12-13 20:26 ` [PATCH net-next-2.6 v9 05/20] pch_can: Fix warnings David Miller
2010-12-13 20:26 ` [PATCH net-next-2.6 v9 04/20] pch_can: Improve rx processing David Miller
2010-12-13 20:26 ` [PATCH net-next-2.6 v9 03/20] pch_can: Fix endianness issue David Miller
2010-12-13 20:26 ` [PATCH net-next-2.6 v9 02/20] pch_can: Divide poll function David Miller
2010-12-13 20:26 ` [PATCH net-next-2.6 v9 01/20] pch_can: Add flow control processing David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292221467-8039-13-git-send-email-tomoya-linux@dsn.okisemi.com \
--to=tomoya-linux-ecg8zkttlr0c6lszws/t0g@public.gmane.org \
--cc=21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=chripell-VaTbYqLCNhc@public.gmane.org \
--cc=joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TZUIDd8j+nm9g@public.gmane.org \
--cc=margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
--cc=yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).