From: Ben Hutchings <bhutchings@solarflare.com>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org, sathyap@serverengines.com,
subbus@serverengines.com, sarveshwarb@serverengines.com,
ajitk@serverengines.com, davem@davemloft.net
Subject: Re: [PATCH net-2.6] be2net: use semaphore instead of spin lock for mbox_lock
Date: Tue, 14 Dec 2010 14:21:23 +0000 [thread overview]
Message-ID: <1292336483.20458.1.camel@bwh-desktop> (raw)
In-Reply-To: <1292334367-11148-1-git-send-email-ivecera@redhat.com>
On Tue, 2010-12-14 at 14:46 +0100, Ivan Vecera wrote:
> Since the mbox polling uses the schedule_timeout, the mbox_lock should be
> a semaphore and not a spin lock.
> The commit f25b03a replaced udelay() with schedule_timeout() but didn't
> change the mbox_lock to a semaphore or a mutex.
[...]
I see no reason for this to be a semaphore; use a mutex instead.
Ben
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-12-14 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 13:46 [PATCH net-2.6] be2net: use semaphore instead of spin lock for mbox_lock Ivan Vecera
2010-12-14 14:21 ` Ben Hutchings [this message]
2010-12-14 15:43 ` [PATCH net-2.6] be2net: use mutex " Ivan Vecera
2010-12-16 22:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292336483.20458.1.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=ajitk@serverengines.com \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sarveshwarb@serverengines.com \
--cc=sathyap@serverengines.com \
--cc=subbus@serverengines.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).