From: Eric Dumazet <eric.dumazet@gmail.com>
To: Flavio Leitner <fleitner@redhat.com>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH] e1000e: convert to stats64
Date: Tue, 14 Dec 2010 22:29:33 +0100 [thread overview]
Message-ID: <1292362173.2478.6.camel@edumazet-laptop> (raw)
In-Reply-To: <1292358735-32089-1-git-send-email-fleitner@redhat.com>
Le mardi 14 décembre 2010 à 18:32 -0200, Flavio Leitner a écrit :
> Provides accurate stats at the time user reads them.
>
> Signed-off-by: Flavio Leitner <fleitner@redhat.com>
> ---
> drivers/net/e1000e/e1000.h | 5 ++-
> drivers/net/e1000e/ethtool.c | 27 +++++++++-------
> drivers/net/e1000e/netdev.c | 68 ++++++++++++++++++++++++-----------------
> 3 files changed, 59 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/net/e1000e/e1000.h b/drivers/net/e1000e/e1000.h
> index fdc67fe..5a5e944 100644
> --- a/drivers/net/e1000e/e1000.h
> +++ b/drivers/net/e1000e/e1000.h
> @@ -363,6 +363,8 @@ struct e1000_adapter {
> /* structs defined in e1000_hw.h */
> struct e1000_hw hw;
>
> + spinlock_t stats64_lock;
> + struct rtnl_link_stats64 stats64;
I am not sure why you add this stats64 in e1000_adapter ?
Why isnt it provided by callers (automatic variable, or provided to
ndo_get_stats64()). I dont see accumulators, only a full rewrite of this
structure in e1000e_update_stats() ?
next prev parent reply other threads:[~2010-12-14 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 20:32 [PATCH] e1000e: convert to stats64 Flavio Leitner
2010-12-14 21:29 ` Eric Dumazet [this message]
2010-12-16 12:31 ` [PATCH v2] " Flavio Leitner
2010-12-16 12:50 ` Eric Dumazet
2010-12-16 13:10 ` Flavio Leitner
2010-12-16 13:18 ` Eric Dumazet
2010-12-17 3:14 ` Jeff Kirsher
2011-01-21 17:03 ` Flavio Leitner
2011-01-21 22:19 ` Jeff Kirsher
2010-12-15 23:59 ` [PATCH] " Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292362173.2478.6.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=fleitner@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox