From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: [PATCH] net/sunrpc/auth_gss/gss_krb5_crypto.c: Use normal negative error value return Date: Tue, 14 Dec 2010 16:34:25 -0500 Message-ID: <1292362465.14641.10.camel@heimdal.trondhjem.org> References: <1289786891.16461.102.camel@Joe-Laptop> <20101214211922.GJ24828@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: Joe Perches , Neil Brown , "David S. Miller" , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "J. Bruce Fields" Return-path: In-Reply-To: <20101214211922.GJ24828-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Tue, 2010-12-14 at 16:19 -0500, J. Bruce Fields wrote: > On Sun, Nov 14, 2010 at 06:08:11PM -0800, Joe Perches wrote: > > And remove unnecessary double semicolon too. > > > > No effect to code, as test is != 0. > > Hm, the error return's actually ignored. But OK. Applying to my tree > for 2.6.38 assuming nobody else has picked it up. There are also gems such as u32 ret = -EINVAL; Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html