* [PATCH] net/sunrpc/auth_gss/gss_krb5_crypto.c: Use normal negative error value return
@ 2010-11-15 2:08 Joe Perches
2010-12-14 21:19 ` J. Bruce Fields
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2010-11-15 2:08 UTC (permalink / raw)
To: J. Bruce Fields, Neil Brown, Trond Myklebust, David S. Miller
Cc: linux-nfs, netdev, linux-kernel
And remove unnecessary double semicolon too.
No effect to code, as test is != 0.
Signed-off-by: Joe Perches <joe@perches.com>
---
net/sunrpc/auth_gss/gss_krb5_crypto.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c
index 75ee993..9576f35 100644
--- a/net/sunrpc/auth_gss/gss_krb5_crypto.c
+++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
@@ -137,7 +137,7 @@ arcfour_hmac_md5_usage_to_salt(unsigned int usage, u8 salt[4])
ms_usage = 13;
break;
default:
- return EINVAL;;
+ return -EINVAL;
}
salt[0] = (ms_usage >> 0) & 0xff;
salt[1] = (ms_usage >> 8) & 0xff;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/sunrpc/auth_gss/gss_krb5_crypto.c: Use normal negative error value return
2010-11-15 2:08 [PATCH] net/sunrpc/auth_gss/gss_krb5_crypto.c: Use normal negative error value return Joe Perches
@ 2010-12-14 21:19 ` J. Bruce Fields
[not found] ` <20101214211922.GJ24828-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: J. Bruce Fields @ 2010-12-14 21:19 UTC (permalink / raw)
To: Joe Perches
Cc: Neil Brown, Trond Myklebust, David S. Miller,
linux-nfs-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Sun, Nov 14, 2010 at 06:08:11PM -0800, Joe Perches wrote:
> And remove unnecessary double semicolon too.
>
> No effect to code, as test is != 0.
Hm, the error return's actually ignored. But OK. Applying to my tree
for 2.6.38 assuming nobody else has picked it up.
--b.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
> ---
> net/sunrpc/auth_gss/gss_krb5_crypto.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> index 75ee993..9576f35 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_crypto.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> @@ -137,7 +137,7 @@ arcfour_hmac_md5_usage_to_salt(unsigned int usage, u8 salt[4])
> ms_usage = 13;
> break;
> default:
> - return EINVAL;;
> + return -EINVAL;
> }
> salt[0] = (ms_usage >> 0) & 0xff;
> salt[1] = (ms_usage >> 8) & 0xff;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-14 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-15 2:08 [PATCH] net/sunrpc/auth_gss/gss_krb5_crypto.c: Use normal negative error value return Joe Perches
2010-12-14 21:19 ` J. Bruce Fields
[not found] ` <20101214211922.GJ24828-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2010-12-14 21:34 ` Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).