From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v3 net-next-2.6] netfilter: x_tables: dont block BH while reading counters Date: Thu, 16 Dec 2010 21:40:08 +0100 Message-ID: <1292532008.2655.8.camel@edumazet-laptop> References: <1292337974.9155.68.camel@firesoul.comx.local> <1292340702.5934.5.camel@edumazet-laptop> <1292342958.9155.91.camel@firesoul.comx.local> <1292343855.5934.27.camel@edumazet-laptop> <1292508266.31289.12.camel@firesoul.comx.local> <1292508733.2883.152.camel@edumazet-laptop> <1292509489.31289.20.camel@firesoul.comx.local> <1292509775.2883.187.camel@edumazet-laptop> <1292511761.2883.236.camel@edumazet-laptop> <1292515625.2883.336.camel@edumazet-laptop> <1292518436.2883.393.camel@edumazet-laptop> <20101216093149.71f082c7@nehalam> <1292521986.2883.472.camel@edumazet-laptop> <20101216095709.18f16c53@nehalam> <1292529519.2655.4.camel@edumazet-laptop> <20101216121238.53deb370@nehalam> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jesper Dangaard Brouer , Patrick McHardy , Arnaldo Carvalho de Melo , Steven Rostedt , Alexander Duyck , netfilter-devel , netdev , Peter P Waskiewicz Jr To: Stephen Hemminger Return-path: In-Reply-To: <20101216121238.53deb370@nehalam> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Le jeudi 16 d=C3=A9cembre 2010 =C3=A0 12:12 -0800, Stephen Hemminger a = =C3=A9crit : > You changed from: > get local cpu counters > then sum other cpus > to: > sum all cpu's. >=20 > This is fine, and will give the same answer.=20 >=20 Yes, I did that because the fetch of individual counters is now more complex. I tried to make code smaller and less complex. Eventually we are now allowed to be preempted and even migrated to another cpu during the process. -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html