From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Changli Gao <xiaosuo@gmail.com>, netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next-2.6] net: force a fresh timestamp for ingress packets
Date: Fri, 17 Dec 2010 10:26:28 +0100 [thread overview]
Message-ID: <1292577988.2906.1.camel@edumazet-laptop> (raw)
In-Reply-To: <20101217085937.GC6907@ff.dom.local>
Le vendredi 17 décembre 2010 à 08:59 +0000, Jarek Poplawski a écrit :
> On Fri, Dec 17, 2010 at 08:34:13AM +0000, Jarek Poplawski wrote:
> > On Fri, Dec 17, 2010 at 09:08:17AM +0100, Eric Dumazet wrote:
> > > Care to suggest an alternative patch, because I am lost at this point ?
> >
> > Just what I wrote earlier: consider one additional cloning in
> > dev_queue_xmit_nit
>
> Actually, it's enough to get time once and change it for all current
> clones in the loop.
>
> Jarek P.
I think we can add this after latest Changli patch :
He does one skb_clone() before calling the sniffers.
We could set timestamp on this clone, instead of original skb.
Problem solved.
next prev parent reply other threads:[~2010-12-17 9:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 15:50 [PATCH net-next-2.6] net: force a fresh timestamp for ingress packets Eric Dumazet
2010-12-16 21:17 ` Jarek Poplawski
2010-12-16 21:30 ` Eric Dumazet
2010-12-16 22:08 ` Jarek Poplawski
2010-12-16 22:26 ` Eric Dumazet
2010-12-16 22:42 ` Jarek Poplawski
2010-12-16 23:31 ` Eric Dumazet
2010-12-17 7:30 ` Jarek Poplawski
2010-12-17 8:08 ` Eric Dumazet
2010-12-17 8:34 ` Jarek Poplawski
2010-12-17 8:59 ` Jarek Poplawski
2010-12-17 9:26 ` Eric Dumazet [this message]
2010-12-21 7:22 ` [PATCH net-next-2.6] net: timestamp cloned packet in dev_queue_xmit_nit Eric Dumazet
2010-12-21 7:56 ` Changli Gao
2010-12-21 18:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292577988.2906.1.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox