* [PATCH net-next-2.6] ifb: fix a lockdep splat
@ 2010-12-16 9:52 Eric Dumazet
2010-12-16 10:00 ` Changli Gao
2010-12-17 13:09 ` jamal
0 siblings, 2 replies; 5+ messages in thread
From: Eric Dumazet @ 2010-12-16 9:52 UTC (permalink / raw)
To: David Miller; +Cc: changli Gao, netdev, Jamal Hadi Salim
After recent ifb changes, we must use lockless __skb_dequeue() since
lock is not anymore initialized.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jamal Hadi Salim <hadi@cyberus.ca>
Cc: Changli Gao <xiaosuo@gmail.com>
---
drivers/net/ifb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index bfa03db..8bcacd7 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -71,7 +71,7 @@ static void ri_tasklet(unsigned long dev)
}
}
- while ((skb = skb_dequeue(&dp->tq)) != NULL) {
+ while ((skb = __skb_dequeue(&dp->tq)) != NULL) {
u32 from = G_TC_FROM(skb->tc_verd);
skb->tc_verd = 0;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next-2.6] ifb: fix a lockdep splat
2010-12-16 9:52 [PATCH net-next-2.6] ifb: fix a lockdep splat Eric Dumazet
@ 2010-12-16 10:00 ` Changli Gao
2010-12-16 22:55 ` David Miller
2010-12-17 13:09 ` jamal
1 sibling, 1 reply; 5+ messages in thread
From: Changli Gao @ 2010-12-16 10:00 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev, Jamal Hadi Salim
On Thu, Dec 16, 2010 at 5:52 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> After recent ifb changes, we must use lockless __skb_dequeue() since
> lock is not anymore initialized.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Jamal Hadi Salim <hadi@cyberus.ca>
> Cc: Changli Gao <xiaosuo@gmail.com>
Acked-by: Changli Gao <xiaosuo@gmail.com>
Then, I have to refine my patch series. Thanks.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next-2.6] ifb: fix a lockdep splat
2010-12-16 10:00 ` Changli Gao
@ 2010-12-16 22:55 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2010-12-16 22:55 UTC (permalink / raw)
To: xiaosuo; +Cc: eric.dumazet, netdev, hadi
From: Changli Gao <xiaosuo@gmail.com>
Date: Thu, 16 Dec 2010 18:00:50 +0800
> On Thu, Dec 16, 2010 at 5:52 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> After recent ifb changes, we must use lockless __skb_dequeue() since
>> lock is not anymore initialized.
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>> Cc: Jamal Hadi Salim <hadi@cyberus.ca>
>> Cc: Changli Gao <xiaosuo@gmail.com>
>
> Acked-by: Changli Gao <xiaosuo@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next-2.6] ifb: fix a lockdep splat
2010-12-16 9:52 [PATCH net-next-2.6] ifb: fix a lockdep splat Eric Dumazet
2010-12-16 10:00 ` Changli Gao
@ 2010-12-17 13:09 ` jamal
2010-12-17 13:15 ` Eric Dumazet
1 sibling, 1 reply; 5+ messages in thread
From: jamal @ 2010-12-17 13:09 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, changli Gao, netdev
On Thu, 2010-12-16 at 10:52 +0100, Eric Dumazet wrote:
> After recent ifb changes, we must use lockless __skb_dequeue() since
> lock is not anymore initialized.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Jamal Hadi Salim <hadi@cyberus.ca>
> Cc: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
cheers,
jamal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next-2.6] ifb: fix a lockdep splat
2010-12-17 13:09 ` jamal
@ 2010-12-17 13:15 ` Eric Dumazet
0 siblings, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2010-12-17 13:15 UTC (permalink / raw)
To: hadi; +Cc: David Miller, changli Gao, netdev
Le vendredi 17 décembre 2010 à 08:09 -0500, jamal a écrit :
> On Thu, 2010-12-16 at 10:52 +0100, Eric Dumazet wrote:
> > After recent ifb changes, we must use lockless __skb_dequeue() since
> > lock is not anymore initialized.
> >
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> > Cc: Jamal Hadi Salim <hadi@cyberus.ca>
> > Cc: Changli Gao <xiaosuo@gmail.com>
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Thanks for reviewing Jamal !
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-12-17 13:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-16 9:52 [PATCH net-next-2.6] ifb: fix a lockdep splat Eric Dumazet
2010-12-16 10:00 ` Changli Gao
2010-12-16 22:55 ` David Miller
2010-12-17 13:09 ` jamal
2010-12-17 13:15 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).