From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: John Fastabend <john.r.fastabend@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org, hadi@cyberus.ca,
shemminger@vyatta.com, tgraf@infradead.org,
nhorman@tuxdriver.com
Subject: Re: [net-next-2.6 PATCH v2] net: implement mechanism for HW based QOS
Date: Mon, 20 Dec 2010 23:58:51 +0100 [thread overview]
Message-ID: <1292885931.2627.128.camel@edumazet-laptop> (raw)
In-Reply-To: <1292885287.3055.22.camel@bwh-desktop>
Le lundi 20 décembre 2010 à 22:48 +0000, Ben Hutchings a écrit :
> That seems like a fair amount of data to add to every net device,
> considering that users may create e.g. a lot of VLAN devices and they
> won't use this state at all. Have you considered putting these in a
> structure that is accessed indirectly?
Yes, this was like this in previous patch, but I asked John to put it in
netdevice instead, in order to avoid a false sharing and this
indirection.
This adds 64 bytes on a netdevice. Most machines dont have more than 16
netdevices, it seems a reasonable cost. (We removed the ingress bloat
some time ago, so no significant increase anyway)
next prev parent reply other threads:[~2010-12-20 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 16:56 [net-next-2.6 PATCH v2] net: implement mechanism for HW based QOS John Fastabend
2010-12-20 22:48 ` Ben Hutchings
2010-12-20 22:58 ` Stephen Hemminger
2010-12-20 22:58 ` Eric Dumazet [this message]
2010-12-21 19:15 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292885931.2627.128.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=shemminger@vyatta.com \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox