From: jamal <hadi@cyberus.ca>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Stephen Hemminger <shemminger@linux-foundation.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Tom Herbert <therbert@google.com>, Jiri Pirko <jpirko@redhat.com>,
netdev@vger.kernel.org, netem@lists.linux-foundation.org
Subject: Re: [PATCH 5/5 v4] net: add old_queue_mapping into skb->cb
Date: Tue, 21 Dec 2010 08:07:17 -0500 [thread overview]
Message-ID: <1292936837.6535.8.camel@mojatatu> (raw)
In-Reply-To: <AANLkTi=Eq1HuPwMMGQjk9x0QXp3_5djmAY6JeZyFkk0k@mail.gmail.com>
On Fri, 2010-12-17 at 21:41 +0800, Changli Gao wrote:
Sorry for the latency - I am a little swamped.
> I doubt it can work.
It should work - this used to be part of my regression tests.
If it doesnt work something is broken.
In any case, I shouldnt have used this example because
it distracted from the point i was trying to make:
You are restoring the old qmap when the point is we could change
it to a new one. A simpler example illustrating how
a qmap could be changed:
----
tc filter add dev ifb0 parent 1:0 protocol ip prio 10 u32 \
match u32 0 0 flowid 1:2 \
action skbedit queue_mapping 4
---
cheers,
jamal
next prev parent reply other threads:[~2010-12-21 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 4:56 [PATCH 5/5 v4] net: add old_queue_mapping into skb->cb Changli Gao
2010-12-16 5:47 ` Eric Dumazet
2010-12-17 13:09 ` jamal
2010-12-17 13:41 ` Changli Gao
2010-12-21 13:07 ` jamal [this message]
2010-12-21 14:03 ` Changli Gao
2010-12-21 15:24 ` Eric Dumazet
2010-12-22 0:08 ` Changli Gao
2010-12-23 13:21 ` jamal
2010-12-23 13:00 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292936837.6535.8.camel@mojatatu \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netem@lists.linux-foundation.org \
--cc=shemminger@linux-foundation.org \
--cc=therbert@google.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).