From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: Avinash Repaka <avinash.repaka@oracle.com>, linux-rdma@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] RDS: IB: Initialize max_items based on underlying device attributes
Date: Tue, 3 Oct 2017 18:07:59 -0700 [thread overview]
Message-ID: <1292cf1e-bbc7-9ee6-aafc-29d2e5c8befb@oracle.com> (raw)
In-Reply-To: <1507078237-32366-1-git-send-email-avinash.repaka@oracle.com>
Hi Avinash,
On 10/3/2017 5:50 PM, Avinash Repaka wrote:
> Use max_1m_mrs/max_8k_mrs while setting max_items, as the former
> variables are set based on the underlying device attricutes.
>
s/attricutes/attributes
> Signed-off-by: Avinash Repaka <avinash.repaka@oracle.com>
> ---
> net/rds/ib_rdma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
This patch is fine but it will be nice if you can collect
these changes in series as you are trying to update the
FRWR support. Like this patch and other cleanup patch
you posted yesterday.
With that log fixed,
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
prev parent reply other threads:[~2017-10-04 1:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 0:50 [PATCH net] RDS: IB: Initialize max_items based on underlying device attributes Avinash Repaka
2017-10-04 1:07 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292cf1e-bbc7-9ee6-aafc-29d2e5c8befb@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=avinash.repaka@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).