netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rasesh Mody <rmody@brocade.com>
To: <netdev@vger.kernel.org>
Cc: Rasesh Mody <rmody@brocade.com>, Debashis Dutt <ddutt@brocade.com>
Subject: [PATCH 03/10] bna: Fix ethtool register dump and reordered an API
Date: Tue, 21 Dec 2010 23:23:09 -0800	[thread overview]
Message-ID: <1293002596-3239-4-git-send-email-rmody@brocade.com> (raw)
In-Reply-To: <1293002596-3239-1-git-send-email-rmody@brocade.com>

Change details:
	- Removed semaphore register dump from ethtool
	- Moved netif_carrier_off() call to before calling bna_init()

Signed-off-by: Debashis Dutt <ddutt@brocade.com>
Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 drivers/net/bna/bnad.c         |    8 +++-----
 drivers/net/bna/bnad_ethtool.c |    4 ----
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/net/bna/bnad.c b/drivers/net/bna/bnad.c
index 7bf7977..348ebf9 100644
--- a/drivers/net/bna/bnad.c
+++ b/drivers/net/bna/bnad.c
@@ -3061,6 +3061,9 @@ bnad_pci_probe(struct pci_dev *pdev,
 	/* Initialize netdev structure, set up ethtool ops */
 	bnad_netdev_init(bnad, using_dac);
 
+	/* Set link to down state */
+	netif_carrier_off(netdev);
+
 	bnad_enable_msix(bnad);
 
 	/* Get resource requirement form bna */
@@ -3114,11 +3117,6 @@ bnad_pci_probe(struct pci_dev *pdev,
 
 	mutex_unlock(&bnad->conf_mutex);
 
-	/*
-	 * Make sure the link appears down to the stack
-	 */
-	netif_carrier_off(netdev);
-
 	/* Finally, reguister with net_device layer */
 	err = register_netdev(netdev);
 	if (err) {
diff --git a/drivers/net/bna/bnad_ethtool.c b/drivers/net/bna/bnad_ethtool.c
index 11fa2ea..3011110 100644
--- a/drivers/net/bna/bnad_ethtool.c
+++ b/drivers/net/bna/bnad_ethtool.c
@@ -330,10 +330,6 @@ do {								\
 
 	BNAD_GET_REG(PCIE_MISC_REG);
 
-	BNAD_GET_REG(HOST_SEM0_REG);
-	BNAD_GET_REG(HOST_SEM1_REG);
-	BNAD_GET_REG(HOST_SEM2_REG);
-	BNAD_GET_REG(HOST_SEM3_REG);
 	BNAD_GET_REG(HOST_SEM0_INFO_REG);
 	BNAD_GET_REG(HOST_SEM1_INFO_REG);
 	BNAD_GET_REG(HOST_SEM2_INFO_REG);
-- 
1.7.1


  parent reply	other threads:[~2010-12-22  7:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22  7:23 [PATCH 00/10] bna: Update Brocade BNA Ethernet driver to v2.3.2.3 Rasesh Mody
2010-12-22  7:23 ` [PATCH 01/10] bna: TxRx and datapath fix Rasesh Mody
2010-12-22 23:12   ` David Miller
2010-12-22 23:44     ` Rasesh Mody
2010-12-22  7:23 ` [PATCH 02/10] bna: Port enable disable sync and txq priority fix Rasesh Mody
2010-12-22  7:23 ` Rasesh Mody [this message]
2010-12-22  7:23 ` [PATCH 04/10] bna: Enable pure priority tagged packet reception and rxf uninit cleanup fix Rasesh Mody
2010-12-22  7:23 ` [PATCH 05/10] bna: Fix for TX queue Rasesh Mody
2010-12-22  7:23 ` [PATCH 06/10] bna: IOC uninit check and misc cleanup Rasesh Mody
2010-12-22  7:23 ` [PATCH 07/10] bna: Removed unused code Rasesh Mody
2010-12-22  7:23 ` [PATCH 08/10] bna: Restore VLAN filter table Rasesh Mody
2010-12-22  7:23 ` [PATCH 09/10] bna: IOC failure auto recovery fix Rasesh Mody
2010-12-22  7:23 ` [PATCH 10/10] bna: Update the driver version to 2.3.2.3 Rasesh Mody
2010-12-26  3:18 ` [PATCH 00/10] bna: Update Brocade BNA Ethernet driver to v2.3.2.3 David Miller
2010-12-26  3:24   ` Rasesh Mody
  -- strict thread matches above, loose matches on Subject: below --
2010-12-24  7:45 Rasesh Mody
2010-12-24  7:45 ` [PATCH 03/10] bna: Fix ethtool register dump and reordered an API Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293002596-3239-4-git-send-email-rmody@brocade.com \
    --to=rmody@brocade.com \
    --cc=ddutt@brocade.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).