From: Dan Carpenter <dan.carpenter@linaro.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
amadeuszx.slawinski@linux.intel.com,
Tony Nguyen <anthony.l.nguyen@intel.com>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com,
netdev@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [RFC PATCH] cleanup: make scoped_guard() to be return-friendly
Date: Mon, 30 Sep 2024 14:08:26 +0300 [thread overview]
Message-ID: <129309f3-93d6-4926-8af1-b8d5ea995d48@stanley.mountain> (raw)
In-Reply-To: <84f41bd3-2e98-4d69-9075-d808faece2ce@intel.com>
On Mon, Sep 30, 2024 at 12:21:44PM +0200, Przemek Kitszel wrote:
>
> Most of the time it is just easier to bend your driver than change or
> extend the core of the kernel.
>
> There is actually scoped_cond_guard() which is a trylock variant.
>
> scoped_guard(mutex_try, &ts->mutex) you have found is semantically
> wrong and must be fixed.
What? I'm so puzzled by this conversation.
Anyway, I don't have a problem with your goal, but your macro is wrong and will
need to be re-written. You will need to update any drivers which use the
scoped_guard() for try locks. I don't care how you do that. Use
scoped_cond_guard() if you want or invent a new macro. But that work always
falls on the person changing the API. Plus, it's only the one tsc200x-core.c
driver so I don't understand why you're making a big deal about it.
regards,
dan carpenter
next prev parent reply other threads:[~2024-09-30 11:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 13:41 [RFC PATCH] cleanup: make scoped_guard() to be return-friendly Przemek Kitszel
2024-09-27 7:31 ` Dan Carpenter
2024-09-27 14:08 ` Przemek Kitszel
2024-09-27 15:04 ` Dan Carpenter
2024-09-30 10:21 ` Przemek Kitszel
2024-09-30 11:08 ` Dan Carpenter [this message]
2024-09-30 11:30 ` Przemek Kitszel
2024-09-30 12:57 ` Dan Carpenter
2024-09-30 13:07 ` Dmitry Torokhov
2024-09-30 12:57 ` Dmitry Torokhov
2024-09-30 11:30 ` Markus Elfring
2024-09-30 12:33 ` Przemek Kitszel
2024-09-30 12:51 ` [RFC] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=129309f3-93d6-4926-8af1-b8d5ea995d48@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=peterz@infradead.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox