From: David Sterba <dsterba@suse.cz>
To: mcarlson@broadcom.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Sterba <dsterba@suse.cz>, Michael Chan <mchan@broadcom.com>
Subject: [PATCH] tg3: fix return value check in tg3_read_vpd()
Date: Mon, 27 Dec 2010 18:31:34 +0100 [thread overview]
Message-ID: <1293471094-28976-1-git-send-email-dsterba@suse.cz> (raw)
CC: Matt Carlson <mcarlson@broadcom.com>
CC: Michael Chan <mchan@broadcom.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
---
drivers/net/tg3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 30ccbb6..6f97b7b 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -12658,7 +12658,7 @@ static void __devinit tg3_read_vpd(struct tg3 *tp)
cnt = pci_read_vpd(tp->pdev, pos,
TG3_NVM_VPD_LEN - pos,
&vpd_data[pos]);
- if (cnt == -ETIMEDOUT || -EINTR)
+ if (cnt == -ETIMEDOUT || cnt == -EINTR)
cnt = 0;
else if (cnt < 0)
goto out_not_found;
--
1.7.3.4.626.g73e7b
next reply other threads:[~2010-12-27 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 17:31 David Sterba [this message]
2010-12-27 20:19 ` [PATCH] tg3: fix return value check in tg3_read_vpd() Dan Carpenter
2010-12-29 13:17 ` David Sterba
2010-12-29 13:40 ` [PATCH v2] " David Sterba
2010-12-31 20:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293471094-28976-1-git-send-email-dsterba@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).