Re: [PATCH v4] Gemini: Gigabit ethernet driver

[Joe Perches <joe@perches.com>]

On Thu, 2010-12-30 at 09:39 +0100, Michał Mirosław wrote:
> Driver for SL351x (Gemini) SoC ethernet peripheral. Based in part
> on work by Paulius Zaleckas and GPLd code from Raidsonic and other
> NAS vendors.
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> diff --git a/drivers/net/sl351x.c b/drivers/net/sl351x.c

Output trivia:

> +static void gmac_tx_interrupt(struct net_device *dev, unsigned txq_num)
[]
> +	netif_info(gmac, tx_done, dev, "txirq%u: %u,%u,%u\n",
> +		txq_num, txq->cptr, GET_RPTR(ptr_reg), GET_WPTR(ptr_reg));

pointers as decimal?
There seems to be a lot of output using %u where I expected %08x.

> +static int gmac_start_xmit(struct sk_buff *skb, struct net_device *dev)
[]
> +	netif_info(gmac, tx_queued, dev, "txq%u: %u,%u,%u ? %p (%u @ %p) /%u\n",
> +		txq_num, txq->cptr, GET_RPTR(ptr_reg), GET_WPTR(ptr_reg),
> +		skb, skb->len, skb->data, skb_shinfo(skb)->gso_size);
[]
> +	netif_info(gmac, tx_queued, dev, "txq%u: %u,%u,%u + %p\n",
> +		txq_num, txq->cptr, GET_RPTR(ptr_reg), w, skb);
[]
> +static unsigned gmac_rx(struct net_device *dev, unsigned budget)
[]
> +	netif_info(gmac, rx_status, dev, "rxq: %u,%u\n",
> +		 GET_RPTR(ptr_reg), GET_WPTR(ptr_reg));

etc...