Re: [PATCH] UDPCP Communication Protocol

Jesper Juhl
2011-01-10T22:53:18Z

stefani@seibold.net wrote:
+static int udpcp_xmit(struct sock *sk, struct udpcp_dest *dest)
+{
+ struct udpcp_sock *usk = udpcp_sk(sk);
+ int ret;
+
+ ret = _udpcp_xmit(sk, dest);
+
+ if (dest->xmit_wait) {
+ dest->tx_time = jiffies;
+
+ if (!timer_pending(&usk->timer))
+ udpcp_timer(sk, dest->tx_time + usk->tx_timeout);
+ }
+ return ret;
+}

Wouldn't this be slightly nicer as

static int udpcp_xmit(struct sock *sk, struct udpcp_dest *dest)
{
int ret = _udpcp_xmit(sk, dest);

if (dest->xmit_wait) {
struct udpcp_sock *usk = udpcp_sk(sk);
dest->tx_time = jiffies;
if (!timer_pending(&usk->timer))
udpcp_timer(sk, dest->tx_time + usk->tx_timeout);
}
return ret;
}

??

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.