Re: [PATCH] new UDPCP Communication Protocol

Eric Dumazet
2011-01-11T21:06:17Z

Le mardi 11 janvier 2011 à 21:50 +0100, Stefani Seibold a écrit :
> Am Dienstag, den 11.01.2011, 18:01 +0100 schrieb Eric Dumazet:
> > Le mardi 11 janvier 2011 à 17:48 +0100, stefani@seibold.net a écrit :
> > > From: Stefani Seibold <stefani@seibold.net>
> > >
> > ...
> > > The implementation is clean and has absolut no side effects to the network
> > > subsystems so i ask for merge it into linux, mm-tree or linux-next.
> > >
> > > The patch is against the current linux git tree
> > >
> > > - Stefani
> > >
> > > Signed-off-by: Stefani Seibold <stefani@seibold.net>
> > > ---
> > >
> >
> > Reading again UDPCP specs, I find it is IPv4/IPv6 agnostic
> >
> > You copied IPv4 UDP code, so this only handles IPv4...
> >
>
> Right, but currently there is no need for an IPV6 implementation, non of
> our base station provide it and non of our mobile network customers use
> it.
>
> If it will be required in the future it will be implemented.
>
>

All I wanted to point out is the implementation you did, using a copy of
code instead of stacked layer, makes this ipv6 a whole rewrite.

Better understand know the implications, before code inclusion.

I understand your code satisfies your immediate needs (and companies
that paid this development), but we should make a step forward in code
reuse.