Re: [PATCH] new UDPCP Communication Protocol

Stefani Seibold
2011-01-11T21:40:58Z

Am Dienstag, den 11.01.2011, 13:19 -0800 schrieb David Miller:
> From: Stefani Seibold <stefani@seibold.net>
> Date: Tue, 11 Jan 2011 22:14:40 +0100
>
> > If nobody need it and no user in the near future out there, why should i
> > implement this? That is dogmatic only!
>
> It's a hard requirement, sorry.
>
> And I want you to do it especially because it shows clearly how poor
> your implementation is, with all of it's code duplication.
>

First it is not so much code duplication. It it less than 20 percent of
the whole code. And most of this code was adapted to the need of the
protocol.

Second, the design is may in your opinion poor. I like it. What is
really poor is the kernel_...() socket functions, which are only simple
wrapper of the system calls without any performance improvement, skb
support and memory saving.

IPv6 would not very hard to implement and will be done if i get an go.

> You'll need yet another copy of all of this code to support ipv6.
>
> Please implement this properly, and in doing so the ipv6 support will
> be very simple if not trivial.

The implementation is clean and fast, it has absolut no side effect. It
is save to merge and all requirement was solved.