From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Joe Perches <joe@perches.com>, Joel Sing <jsing@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4/route.c: respect prefsrc for local routes
Date: Tue, 04 Jan 2011 09:38:35 +0100 [thread overview]
Message-ID: <1294130315.2711.48.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTimDms0FTmXWf9WSpcxwZXVVSXQj44jZ2Ag8Osuk@mail.gmail.com>
Le mardi 04 janvier 2011 à 16:07 +0800, Changli Gao a écrit :
> On Tue, Jan 4, 2011 at 3:33 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > Le mardi 04 janvier 2011 à 08:24 +0100, Eric Dumazet a écrit :
> >
> >> Please use FIB_RES_PREFSRC(res)
> >>
> >
> > Hmm no, this is not applicable, but this could be shorter :
> >
> > fl.fl4_src = res.fi->fib_prefsrc ? : fl.fl4_dst;
> >
> >
>
> I think Joe may object the use of "? :"
>
Ternary operator is standard C idiom, used in networking stuff, for
example in FIB_RES_PREFSRC() ;)
This could be properly done using another macro in include/net/ip_fib.h
to centralize this ternary op in one point :
#define __FIB_RES_PREFSRC(res, default) ((res).fi->fib_prefsrc ? : default)
#define FIB_RES_PREFSRC(res) __FIB_RES_PREFSRC(res, default, __fib_res_prefsrc(&res))
next prev parent reply other threads:[~2011-01-04 8:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 6:24 [PATCH] ipv4/route.c: respect prefsrc for local routes Joel Sing
2011-01-04 7:24 ` Eric Dumazet
2011-01-04 7:33 ` Eric Dumazet
2011-01-04 8:07 ` Changli Gao
2011-01-04 8:38 ` Eric Dumazet [this message]
2011-01-04 8:40 ` Eric Dumazet
2011-01-04 14:16 ` Ben Hutchings
2011-01-04 15:32 ` Joe Perches
2011-01-04 19:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294130315.2711.48.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=jsing@google.com \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox