From: Ben Hutchings <bhutchings@solarflare.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH] ethtool: update get_rx_ntuple to correctly interpret string count
Date: Wed, 05 Jan 2011 00:01:02 +0000 [thread overview]
Message-ID: <1294185662.3636.61.camel@bwh-desktop> (raw)
In-Reply-To: <20110104232947.3451.91153.stgit@gitlad.jf.intel.com>
On Tue, 2011-01-04 at 15:29 -0800, Alexander Duyck wrote:
> Currently any strings returned via the get_rx_ntuple call will just be
> dropped because the num_strings will be zero. In order to correct this I
> am updating things so that the return value of get_rx_ntuple is the number
> of strings that were written, or a negative value if there was an error.
[...]
Nothing implements ethtool_ops::get_rx_ntuple, anyway.
The fallback implementation is totally bogus, too. Maximum of 1024
filters? Erm, sfc can handle more than that. And doing complex string
formatting in the kernel, even though all the parsing is in ethtool?
Please, let's write off ETHTOOL_GRXNTUPLE as a failed experiment and
replace it with a command that behaves more like ETHTOOL_GRXCLSRLALL.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-01-05 0:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 23:29 [net-next-2.6 PATCH] ethtool: update get_rx_ntuple to correctly interpret string count Alexander Duyck
2011-01-05 0:01 ` Ben Hutchings [this message]
2011-01-05 1:06 ` Alexander Duyck
2011-01-05 15:26 ` Ben Hutchings
2011-01-05 16:57 ` Alexander Duyck
2011-01-05 17:28 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294185662.3636.61.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).