Re: [RFC] sched: CHOKe packet scheduler (v0.6)

Stephen Hemminger
2011-01-12T17:27:42Z

On Wed, 12 Jan 2011 08:13:48 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Hi Stephen, here is my v0.6 version :
>
> - Added sanity checks before kcalloc()/kzalloc()
> - Added a __GFP_NOWARN to kcalloc()
> - Added call to qdisc_bstats_update() after commit bfe0d0298f2a67d94d5
> (net_sched: factorize qdisc stats handling)
>
> TODO :
> - Added a stat specific update to track CHOKe probabilistic dual-drops
> I temporarily use requeues counter to make sure our code works

I am going to redo stats and config.
Should thresholds be packet or byte based? I prefer packet
Also leaning towards merging qmax and qlimit together.