From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [RFC] sched: CHOKe packet scheduler (v0.2)
Date: Wed, 05 Jan 2011 21:06:07 +0100
Message-ID: <1294257967.2723.9.camel@edumazet-laptop>
References: <20110104162930.6fa672e3@nehalam>
	 <1294208375.3420.46.camel@edumazet-laptop>
	 <20110105091718.02f8a00f@nehalam>
	 <1294248332.10633.25.camel@edumazet-laptop>
	 <20110105112104.64ad3c86@nehalam>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
To: Stephen Hemminger <shemminger@vyatta.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:56065 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752760Ab1AEUGM (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 5 Jan 2011 15:06:12 -0500
Received: by wyb28 with SMTP id 28so15712060wyb.19
        for <netdev@vger.kernel.org>; Wed, 05 Jan 2011 12:06:11 -0800 (PST)
In-Reply-To: <20110105112104.64ad3c86@nehalam>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Le mercredi 05 janvier 2011 =C3=A0 11:21 -0800, Stephen Hemminger a =C3=
=A9crit :
> This implements the CHOKe packet scheduler based on the existing
> Linux RED scheduler based on the algorithm described in the paper.
>=20

> +
> +static int choke_enqueue(struct sk_buff *skb, struct Qdisc *sch)
> +{
> +	struct choke_sched_data *q =3D qdisc_priv(sch);
> +	struct red_parms *p =3D &q->parms;
> +
> +	p->qavg =3D red_calc_qavg(p, skb_queue_len(&sch->q));
> +	if (red_is_idling(p))
> +		red_end_of_idle_period(p);
> +
> +	if (p->qavg <=3D p->qth_min)
> +		p->qcount =3D -1;
> +	else {
> +		struct sk_buff *oskb;
> +
> +		/* Draw a packet at random from queue */
> +		oskb =3D skb_peek_random(&sch->q);
> +
> +		/* Both packets from same flow?
> +		 * Assumes skb_get_rxhash already set hash on oskb->rxhash
> +		 * prior to queuing

but this is not true... if at that time, p->qavg was <=3D p->qth_min.
Packet was directly enqueued.

Just use :

if (skb_get_rxhash(oskb) =3D=3D skb_get_rxhash(skb))

Since skb_get_rxhash(skb) doesnt recompute rxhash if already set.

Hmm... I am now wondering if this actually works on egress at all
(can we use rxhash here I mean)



> +		 */
> +		if (oskb->rxhash =3D=3D skb_get_rxhash(skb)) {
> +			/* Drop both packets */
> +			__skb_unlink(oskb, &sch->q);
> +			qdisc_drop(oskb, sch);
> +			goto congestion_drop;
> +		}