public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: John Fastabend <john.r.fastabend@intel.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"jarkao2@gmail.com" <jarkao2@gmail.com>,
	"hadi@cyberus.ca" <hadi@cyberus.ca>,
	"shemminger@vyatta.com" <shemminger@vyatta.com>,
	"tgraf@infradead.org" <tgraf@infradead.org>,
	"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [net-next-2.6 PATCH v5 1/2] net: implement mechanism for HW based QOS
Date: Thu, 06 Jan 2011 19:56:31 +0100	[thread overview]
Message-ID: <1294340191.3074.96.camel@edumazet-laptop> (raw)
In-Reply-To: <4D260DC2.6050601@intel.com>

Le jeudi 06 janvier 2011 à 10:45 -0800, John Fastabend a écrit :

> It should still be 64 bytes.
> 
> struct netdev_tc_txq {
>         u16 count;
>         u16 offset;
> };
> 
> struct netdev_tc_txq (4 octets) and TC_MAX_QUEUE = 16, so 4*16 = 64
> 
> +	struct netdev_tc_txq tc_to_txq[TC_MAX_QUEUE];   => 64 octets
> +	u8 prio_tc_map[TC_BITMASK+1];			=> 16 octets
> 
> All together 80 bytes this is certainly in the 512 unused bytes.

Good ;)

Considering a single TCP socket is larger than a net_device, I think its
OK to not worry too much ;)




      reply	other threads:[~2011-01-06 18:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 18:56 [net-next-2.6 PATCH v5 1/2] net: implement mechanism for HW based QOS John Fastabend
2011-01-04 18:56 ` [net-next-2.6 PATCH v5 2/2] net_sched: implement a root container qdisc sch_mqprio John Fastabend
2011-01-04 22:59   ` Jarek Poplawski
2011-01-05 17:38     ` John Fastabend
2011-01-05 17:47       ` Stephen Hemminger
2011-01-06  0:32       ` Jarek Poplawski
2011-01-06  2:31         ` John Fastabend
2011-01-06 15:41           ` Jarek Poplawski
2011-01-06 18:20 ` [net-next-2.6 PATCH v5 1/2] net: implement mechanism for HW based QOS Ben Hutchings
2011-01-06 18:31   ` Eric Dumazet
2011-01-06 18:45     ` John Fastabend
2011-01-06 18:56       ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294340191.3074.96.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=jarkao2@gmail.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=shemminger@vyatta.com \
    --cc=tgraf@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox