Re: [PATCH 2/3] tlan: Fix partner capability printout

[Ben Hutchings <bhutchings@solarflare.com>]

On Thu, 2011-01-06 at 21:36 +0200, Sakari Ailus wrote:
> Ben Hutchings wrote:
> > On Thu, 2011-01-06 at 20:50 +0200, Sakari Ailus wrote:
> >> Fix partner capability printout. Add spaces and do not print null.
> >>
> >> Signed-off-by: Sakari Ailus<sakari.ailus@iki.fi>
> >> ---
> >>   drivers/net/tlan.c |    6 +++---
> >>   1 files changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/net/tlan.c b/drivers/net/tlan.c
> >> index 57380b1..090ce21 100644
> >> --- a/drivers/net/tlan.c
> >> +++ b/drivers/net/tlan.c
> >> @@ -2367,10 +2367,10 @@ tlan_finish_reset(struct net_device *dev)
> >>   					? "" : "0",
> >>   					tlphy_par&  TLAN_PHY_DUPLEX_FULL
> >>   					? "Full" : "half");
> >> -				pr_info("TLAN: Partner capability: ");
> >> -				for (i = 5; i<= 10; i++)
> >> +				pr_info("TLAN: Partner capability:");
> >> +				for (i = 5; i<  10; i++)
> >>   					if (partner&  (1<<i))
> >> -						printk("%s", media[i-5]);
> >> +						printk(" %s", media[i-5]);
> >>   				printk("\n");
> >>   			}
> >>
> >
> > Really you should remove this logging and report the information through
> > the ethtool interface.
> 
> Hi Ben,
> 
> Thanks for the comments.
> 
> The driver supports mii-tool but not ethtool. Do you think it'd be fine 
> to remove these prints with just mii-tool interface support?
> 
> I agree ethtool support would definitely make sense to have in tlan.

Assuming that tlan drives a fairly standard MDIO PHY, you should be able
to implement the PHY-related ethtool operations using
ethtool_op_get_link(), mii_nway_restart(), mii_ethtool_gset() and
mii_ethtool_sset().

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.