From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH 2/3] tlan: Fix partner capability printout Date: Thu, 06 Jan 2011 19:44:46 +0000 Message-ID: <1294343086.11825.31.camel@bwh-desktop> References: <4D260ED0.5040301@iki.fi> <1294339817-31434-1-git-send-email-sakari.ailus@iki.fi> <1294339817-31434-2-git-send-email-sakari.ailus@iki.fi> <1294341774.11825.27.camel@bwh-desktop> <4D2619BC.1030606@iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Sakari Ailus Return-path: Received: from mail.solarflare.com ([216.237.3.220]:6602 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147Ab1AFTot (ORCPT ); Thu, 6 Jan 2011 14:44:49 -0500 In-Reply-To: <4D2619BC.1030606@iki.fi> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2011-01-06 at 21:36 +0200, Sakari Ailus wrote: > Ben Hutchings wrote: > > On Thu, 2011-01-06 at 20:50 +0200, Sakari Ailus wrote: > >> Fix partner capability printout. Add spaces and do not print null. > >> > >> Signed-off-by: Sakari Ailus > >> --- > >> drivers/net/tlan.c | 6 +++--- > >> 1 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/net/tlan.c b/drivers/net/tlan.c > >> index 57380b1..090ce21 100644 > >> --- a/drivers/net/tlan.c > >> +++ b/drivers/net/tlan.c > >> @@ -2367,10 +2367,10 @@ tlan_finish_reset(struct net_device *dev) > >> ? "" : "0", > >> tlphy_par& TLAN_PHY_DUPLEX_FULL > >> ? "Full" : "half"); > >> - pr_info("TLAN: Partner capability: "); > >> - for (i = 5; i<= 10; i++) > >> + pr_info("TLAN: Partner capability:"); > >> + for (i = 5; i< 10; i++) > >> if (partner& (1< >> - printk("%s", media[i-5]); > >> + printk(" %s", media[i-5]); > >> printk("\n"); > >> } > >> > > > > Really you should remove this logging and report the information through > > the ethtool interface. > > Hi Ben, > > Thanks for the comments. > > The driver supports mii-tool but not ethtool. Do you think it'd be fine > to remove these prints with just mii-tool interface support? > > I agree ethtool support would definitely make sense to have in tlan. Assuming that tlan drives a fairly standard MDIO PHY, you should be able to implement the PHY-related ethtool operations using ethtool_op_get_link(), mii_nway_restart(), mii_ethtool_gset() and mii_ethtool_sset(). Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.