From: Eric Dumazet <eric.dumazet@gmail.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Leonardo Chiquitto <leonardo.lists@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: POLLPRI/poll() behavior change since 2.6.31
Date: Fri, 07 Jan 2011 14:31:45 +0100 [thread overview]
Message-ID: <1294407105.3306.32.camel@edumazet-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1101061429080.4928@davide-lnx1>
Le jeudi 06 janvier 2011 à 14:40 -0800, Davide Libenzi a écrit :
> On Thu, 6 Jan 2011, Eric Dumazet wrote:
>
> > Hmm, this is because sock_def_readable() uses :
> >
> > wake_up_interruptible_sync_poll(&wq->wait, POLLIN | POLLRDNORM |
> > POLLRDBAND);
> >
> > So POLLPRI bit is not signaled.
> >
> > I would just add POLLPRI flag in sock_def_readable()
> >
> > (Alternatively, define a tcp_def_readable() function to pass POLLPRI
> > only if TCP_URG is set, but is it worth the pain for a seldom used
> > feature ?)
>
> It would be kinda cleaner though, /me thinks.
>
Yep, we'll do this in net-next-2.6 for 2.6.39 :)
Thanks !
next prev parent reply other threads:[~2011-01-07 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 15:50 POLLPRI/poll() behavior change since 2.6.31 Leonardo Chiquitto
2011-01-06 16:55 ` Eric Dumazet
2011-01-06 18:10 ` Leonardo Chiquitto
2011-01-06 22:40 ` Davide Libenzi
2011-01-07 13:31 ` Eric Dumazet [this message]
2011-01-06 17:44 ` [PATCH] net: add POLLPRI to sock_def_readable() Eric Dumazet
2011-01-06 18:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294407105.3306.32.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=davidel@xmailserver.org \
--cc=leonardo.lists@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox