From: Mike Frysinger <vapier@gentoo.org>
To: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
Sonic Zhang <sonic.zhang@analog.com>
Subject: [PATCH 5/5] netdev: bfin_mac: disable hardware checksum if writeback cache is enabled
Date: Mon, 10 Jan 2011 07:54:33 -0500 [thread overview]
Message-ID: <1294664073-1950-5-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1294664073-1950-1-git-send-email-vapier@gentoo.org>
From: Sonic Zhang <sonic.zhang@analog.com>
With writeback caches, corrupted RX packets will be sent up the stack
without any error markings.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/net/bfin_mac.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bfin_mac.h b/drivers/net/bfin_mac.h
index c1a0d66..f8559ac 100644
--- a/drivers/net/bfin_mac.h
+++ b/drivers/net/bfin_mac.h
@@ -17,7 +17,14 @@
#include <linux/etherdevice.h>
#include <linux/bfin_mac.h>
+/*
+ * Disable hardware checksum for bug #5600 if writeback cache is
+ * enabled. Otherwize, corrupted RX packet will be sent up stack
+ * without error mark.
+ */
+#ifndef CONFIG_BFIN_EXTMEM_WRITEBACK
#define BFIN_MAC_CSUM_OFFLOAD
+#endif
#define TX_RECLAIM_JIFFIES (HZ / 5)
--
1.7.4.rc1
next prev parent reply other threads:[~2011-01-10 12:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 12:54 [PATCH 1/5] netdev: bfin_mac: clean up printk messages Mike Frysinger
2011-01-10 12:54 ` [PATCH 2/5] netdev: bfin_mac: mark setup_system_regs as static Mike Frysinger
2011-01-10 21:31 ` David Miller
2011-01-10 12:54 ` [PATCH 3/5] netdev: bfin_mac: drop unused Mac data Mike Frysinger
2011-01-10 21:31 ` David Miller
2011-01-10 12:54 ` [PATCH 4/5] netdev: bfin_mac: let boards set vlan masks Mike Frysinger
2011-01-10 21:31 ` David Miller
2011-01-10 12:54 ` Mike Frysinger [this message]
2011-01-10 21:31 ` [PATCH 5/5] netdev: bfin_mac: disable hardware checksum if writeback cache is enabled David Miller
2011-01-10 21:31 ` [PATCH 1/5] netdev: bfin_mac: clean up printk messages David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-10-26 7:40 Mike Frysinger
2010-10-26 7:40 ` [PATCH 5/5] netdev: bfin_mac: disable hardware checksum if writeback cache is enabled Mike Frysinger
2010-10-22 5:59 [PATCH 1/5] netdev: bfin_mac: push settings to platform resources Mike Frysinger
2010-10-22 5:59 ` [PATCH 5/5] netdev: bfin_mac: disable hardware checksum if writeback cache is enabled Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294664073-1950-5-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sonic.zhang@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).